From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtZom-0002kf-14 for qemu-devel@nongnu.org; Tue, 03 Nov 2015 06:32:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtZoi-0003E6-QH for qemu-devel@nongnu.org; Tue, 03 Nov 2015 06:31:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtZoi-0003Dr-KY for qemu-devel@nongnu.org; Tue, 03 Nov 2015 06:31:56 -0500 Date: Tue, 3 Nov 2015 11:31:52 +0000 From: "Daniel P. Berrange" Message-ID: <20151103113151.GI10551@redhat.com> References: <1446473183-24250-1-git-send-email-stefanha@redhat.com> <20151103002447.GA6246@ad.usersys.redhat.com> <20151103112213.GA15414@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151103112213.GA15414@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Peter Maydell , Fam Zheng , qemu-devel@nongnu.org, guydavid@outlook.com On Tue, Nov 03, 2015 at 11:22:13AM +0000, Stefan Hajnoczi wrote: > On Tue, Nov 03, 2015 at 08:24:47AM +0800, Fam Zheng wrote: > > On Mon, 11/02 14:06, Stefan Hajnoczi wrote: > > Actually the document is wrong about module support, the default is off: > > These issues are independent of this patch, but... > > > > Optional features, enabled with --enable-FEATURE and > > > disabled with --disable-FEATURE, default is enabled if available: > > > > Maybe we should move it out of this section instead? > > There are other foo="no" default options in this section. > > I think "default is enabled if available" really refers to foo="" > autodetection only. > > > What about vnc-tls? It's described in the same place, but there is no option > > for it. > > Regarding vnc-tls, it was removed in > 3e305e4a4752f70c0b5c3cf5b43ec957881714f7. Maybe Dan can send a > follow-up patch that removes it from the ./configure --help output? Sure, will do. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|