From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] Fix the reopening of images in 'block-commit'
Date: Tue, 3 Nov 2015 13:11:27 +0100 [thread overview]
Message-ID: <20151103121127.GA11009@noname.redhat.com> (raw)
In-Reply-To: <cover.1446039123.git.berto@igalia.com>
Am 28.10.2015 um 14:43 hat Alberto Garcia geschrieben:
> This series fixes a bug in the 'block-commit' operation under the
> following scenario:
>
> [A] <- [B] <- [C] <- [D]
>
> If we do block-commit top=B base=A, the contents of [B] will be
> written into [A] resulting in this chain:
>
> [A] <- [C] <- [D]
>
> In order to perform this operation, [A] must be reopened in read-write
> mode but so does [C] because its backing file string needs to be
> updated to point at [A].
>
> There's a bug in the current code that makes [A] read-only again when
> [C] is reopened. This series includes a fix for that bug plus a test
> case for the scenario.
>
> This affects both master and the 2.4 branch.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2015-11-03 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 13:43 [Qemu-devel] [PATCH 0/2] Fix the reopening of images in 'block-commit' Alberto Garcia
2015-10-28 13:43 ` [Qemu-devel] [PATCH 1/2] commit: reopen overlay_bs before base Alberto Garcia
2015-10-30 19:14 ` Max Reitz
2015-10-28 13:43 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: Test the reopening of overlay_bs in 'block-commit' Alberto Garcia
2015-10-30 19:19 ` Max Reitz
2015-11-03 12:11 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103121127.GA11009@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).