From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtaRD-00008s-2G for qemu-devel@nongnu.org; Tue, 03 Nov 2015 07:11:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtaR7-0006OD-Gl for qemu-devel@nongnu.org; Tue, 03 Nov 2015 07:11:42 -0500 Date: Tue, 3 Nov 2015 13:11:27 +0100 From: Kevin Wolf Message-ID: <20151103121127.GA11009@noname.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 0/2] Fix the reopening of images in 'block-commit' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: Max Reitz , Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org Am 28.10.2015 um 14:43 hat Alberto Garcia geschrieben: > This series fixes a bug in the 'block-commit' operation under the > following scenario: > > [A] <- [B] <- [C] <- [D] > > If we do block-commit top=B base=A, the contents of [B] will be > written into [A] resulting in this chain: > > [A] <- [C] <- [D] > > In order to perform this operation, [A] must be reopened in read-write > mode but so does [C] because its backing file string needs to be > updated to point at [A]. > > There's a bug in the current code that makes [A] read-only again when > [C] is reopened. This series includes a fix for that bug plus a test > case for the scenario. > > This affects both master and the 2.4 branch. Thanks, applied to the block branch. Kevin