From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZtmEq-0006Lb-AK
	for qemu-devel@nongnu.org; Tue, 03 Nov 2015 19:47:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZtmEm-00050K-1I
	for qemu-devel@nongnu.org; Tue, 03 Nov 2015 19:47:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45755)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZtmEl-00050G-ST
	for qemu-devel@nongnu.org; Tue, 03 Nov 2015 19:47:39 -0500
Date: Wed, 4 Nov 2015 08:47:37 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151104004737.GA12644@ad.usersys.redhat.com>
References: <1446473183-24250-1-git-send-email-stefanha@redhat.com>
	<20151103002447.GA6246@ad.usersys.redhat.com>
	<20151103112213.GA15414@stefanha-x1.localdomain>
	<CAFEAcA820OJmi_Bqs7PNdPpf3LspNGD0ESBMfz9BCKz-v4DLtw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA820OJmi_Bqs7PNdPpf3LspNGD0ESBMfz9BCKz-v4DLtw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules
 option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, guydavid@outlook.com

On Tue, 11/03 11:56, Peter Maydell wrote:
> On 3 November 2015 at 11:22, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > On Tue, Nov 03, 2015 at 08:24:47AM +0800, Fam Zheng wrote:
> >> On Mon, 11/02 14:06, Stefan Hajnoczi wrote:
> >> Actually the document is wrong about module support, the default is off:
> >
> > These issues are independent of this patch, but...
> >
> >> > Optional features, enabled with --enable-FEATURE and
> >> > disabled with --disable-FEATURE, default is enabled if available:
> >>
> >> Maybe we should move it out of this section instead?
> >
> > There are other foo="no" default options in this section.
> >
> > I think "default is enabled if available" really refers to foo=""
> > autodetection only.
> 
> I think what it ought to say is something like
> 
> "Optional features: these can be enabled with --enable-FEATURE
> or disabled with --disable-FEATURE. The default (unless otherwise
> specified below) is to autodetect support for the feature, and
> enable it if possible, and disable it if not."
> 
> Then options in the list which don't default to 'autodetect'
> should say so, like 'debug-tcg' does now.

Sounds good to me. For this patch:

Reviewed-by: Fam Zheng <famz@redhat.com>