From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtozH-0004Mv-Ce for qemu-devel@nongnu.org; Tue, 03 Nov 2015 22:43:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtozF-0002QI-MV for qemu-devel@nongnu.org; Tue, 03 Nov 2015 22:43:51 -0500 Date: Wed, 4 Nov 2015 14:44:13 +1100 From: David Gibson Message-ID: <20151104034413.GN21954@voom.redhat.com> References: <1445608598-24485-1-git-send-email-mark.cave-ayland@ilande.co.uk> <56339F4C.6070302@ilande.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qi3SIpffvxS/TM8d" Content-Disposition: inline In-Reply-To: <56339F4C.6070302@ilande.co.uk> Subject: Re: [Qemu-devel] [PATCH 00/13] Mac OS 9 compatibility improvements (upstream rework) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: cormac@c-obrien.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --qi3SIpffvxS/TM8d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 30, 2015 at 04:48:12PM +0000, Mark Cave-Ayland wrote: > On 23/10/15 14:56, Mark Cave-Ayland wrote: >=20 > > This is a rework of Cormac O'Brien's GSoC project to try and boot MacOS= 9 under > > QEMU, the original version of which was posted to the qemu-devel list a= t the > > end of August (https://lists.gnu.org/archive/html/qemu-devel/2015-08/ms= g02521.html). > >=20 > > The patchset consisted of some simple patches from Alex and then a larg= e set of > > CUDA changes supplied as a single patch which were the result of Cormac= analysing > > MOL with Alex's help to try and further the boot process. > >=20 > > In their previous form, the patches were unsuitable for applying upstre= am since > > while they furthered MacOS 9 boot, they also caused a couple of major r= egressions > > such as breaking the mouse and causing Darwin/OS X boot to panic on sta= rtup. > >=20 > > This reworked patchset fixes these regressions, includes some other cle= an-ups=20 > > and more importantly now passes all of my OpenBIOS image boot tests wit= h an=20 > > OpenBIOS binary from SVN trunk (separate pull request to be sent shortl= y). > > Whilst OpenBIOS still needs one additional patch to run the MacOS 9 boo= tloader, > > I've uploaded a pre-compiled binary to=20 > > https://www.ilande.co.uk/tmp/openbios-ppc for people interested in test= ing the=20 > > new MacOS 9 functionality. > >=20 > > Apologies for the delay in sending this out on-list, however due to rec= ent > > circumstances I've been without a reliable broadband connection for a c= ouple > > of weeks. However given that this is mostly a rework of the previous pa= tchset=20 > > and looks good in testing here, I'd definitely like it to be considered= for > > application during soft freeze. > >=20 > > Signed-off-by: Mark Cave-Ayland > >=20 > > Alexander Graf (3): > > PPC: Allow Rc bit to be set on mtspr > > PPC: Fix lsxw bounds checks > > PPC: mac99: Always add USB controller > >=20 > > Mark Cave-Ayland (10): > > cuda.c: fix CUDA ADB error packet format > > cuda.c: fix CUDA_PACKET response packet format > > cuda.c: implement simple CUDA_GET_6805_ADDR command > > cuda.c: implement dummy IIC access commands > > cuda.c: fix CUDA SR interrupt clearing > > cuda.c: add defines for CUDA registers > > cuda.c: refactor get_tb() so that the time can be passed in > > cuda.c: rename get_counter() state variable from s to ti for > > consistency > > cuda.c: fix T2 timer and enable its interrupt > > cuda.c: add delay to setting of SR_INT bit > >=20 > > hw/misc/macio/cuda.c | 243 ++++++++++++++++++++++++++++++---------= -------- > > hw/ppc/mac.h | 3 + > > hw/ppc/mac_newworld.c | 3 +- > > target-ppc/mem_helper.c | 5 +- > > target-ppc/translate.c | 2 +- > > 5 files changed, 163 insertions(+), 93 deletions(-) >=20 > Ping? Can anyone review this in Alex's absence? In the meantime I've > added it to wiki at http://wiki.qemu.org/Planning/2.5 as it would be > good to get the GSoC work upstream for 2.5. Sorry I've taken a while to get to this. It looks pretty good, though I've sent a handful of comments on individual patches. I gathered from one of your replies that you do intend to do a respin. The current comments all look pretty trivial, so I expect I'll be ok to apply your respin to ppc-next (which I'm looking after in agraf's absence). It would be nice to get a review from someone more familiar with, or better able to test MacOS stuff. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --qi3SIpffvxS/TM8d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWOX8NAAoJEGw4ysog2bOSxRsQAIDRG6XJzx0irb3n6xVVlY24 8a5uyfqOuB8X2fmNjv6M++1kvMeWmKSailvEWJoGuPy7zfaUVOOg/CXHmDyKC38n 5KCKQgQRgiyNrTbaBWLtTEBIpKQwurVuDj+QE2KbpIQhL9XdikiA2KeZOsZvIzqH msZzr8UVDHKlrvPt8Nfo/B8hk6H7OQ2ri3FI50LCPjb5D0OUC02Qu53rWIloue3u Q2E+rIQWHuWjP4wMJhYVlzToZou5p7DBnG7tyFjZ/JILEeqYF8c8C5eKIMRlSZZf 1yHPn0x6epK2Cttey7uZ16zmCXWPCpy4bmVBOo0jtn4uPfoxBqdMJyNCjRW1BNe0 k7eXl/R+FmTgiEL7AysYa+CbmV99+Zcnu0V1pLn3iJOPe2P2Rnzq2VHKeuft/5Rk D+LqcATjAR5kSnSrpTDzTOKR6OmlhsuXe/AxZREpKhpzFZr46rE51yUfdAH+fcny /s9WRmUl9DDsAcp+lwzSptaxiUcz2ioJrJeoimJwEZioCjaSyKgnaWB+U+8Uyqlk bOc1SSuEPdpO+cPv3ZnRalhtOxPV/kaQcZva9dvgHVXt33VGzmNKP+h7LKF+CEk0 uUDKlaHg0NRbDQkkcgpnaFpsojWqt+lXp5xjs1SaUFjgjXlPpP5/rYeJexs3Uw4G NqtdiCHoKdBqhCiwfeIE =lJs+ -----END PGP SIGNATURE----- --qi3SIpffvxS/TM8d--