From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qcow2: avoid misaligned 64bit bswap
Date: Wed, 4 Nov 2015 12:08:02 +0100 [thread overview]
Message-ID: <20151104110802.GB4026@noname.redhat.com> (raw)
In-Reply-To: <5637F5F2.4050202@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
Am 03.11.2015 um 00:46 hat Eric Blake geschrieben:
> On 11/02/2015 04:32 PM, John Snow wrote:
> > If we create a buffer directly on the stack by using 12 bytes, there's
> > no guarantee the 64bit value we want to swap will be aligned, which
> > could cause errors with undefined behavior.
> >
> > Spotted with clang -fsanitize=undefined and observed in iotests 15, 26,
> > 44, 115 and 121.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> > block/qcow2-refcount.c | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks, applied to the block branch.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2015-11-04 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 23:32 [Qemu-devel] [PATCH] qcow2: avoid misaligned 64bit bswap John Snow
2015-11-02 23:46 ` Eric Blake
2015-11-04 11:08 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104110802.GB4026@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).