From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] Disallow snapshots if the overlay doesn't support backing files
Date: Thu, 5 Nov 2015 11:56:30 +0100 [thread overview]
Message-ID: <20151105105630.GC3929@noname.redhat.com> (raw)
In-Reply-To: <cover.1446546057.git.berto@igalia.com>
Am 03.11.2015 um 11:32 hat Alberto Garcia geschrieben:
> We are currently allowing snapshots in cases like this one:
>
> { 'execute': 'blockdev-add', 'arguments':
> { 'options': { 'driver': 'qcow2',
> 'node-name': 'new0',
> 'file': { 'driver': 'file',
> 'filename': 'new.qcow2',
> 'node-name': 'file0' } } } }
>
> { 'execute': 'blockdev-snapshot', 'arguments':
> { 'node': 'virtio0',
> 'overlay': 'file0' } }
>
> This patch forbids snapshots if the overlay node does not support
> backing files.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2015-11-05 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 10:32 [Qemu-devel] [PATCH v3 0/3] Disallow snapshots if the overlay doesn't support backing files Alberto Garcia
2015-11-03 10:32 ` [Qemu-devel] [PATCH v3 1/3] block: " Alberto Garcia
2015-11-03 15:14 ` Eric Blake
2015-11-03 10:32 ` [Qemu-devel] [PATCH v3 2/3] block: Remove inner quotation marks in iotest 085 Alberto Garcia
2015-11-03 15:12 ` Eric Blake
2015-11-03 15:27 ` Alberto Garcia
2015-11-03 10:32 ` [Qemu-devel] [PATCH v3 3/3] block: test 'blockdev-snapshot' using a file BDS as the overlay Alberto Garcia
2015-11-03 15:14 ` Eric Blake
2015-11-05 10:56 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105105630.GC3929@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).