From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51144)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1ZuVsa-0004mV-H7
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 20:31:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1ZuVsV-0000Oj-HW
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 20:31:48 -0500
Received: from mga11.intel.com ([192.55.52.93]:20188)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1ZuVsV-0000OJ-95
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 20:31:43 -0500
Date: Fri, 6 Nov 2015 09:34:39 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Message-ID: <20151106013439.GC2326@yliu-dev.sh.intel.com>
References: <1443100738-14970-1-git-send-email-mst@redhat.com>
	<1443100738-14970-13-git-send-email-mst@redhat.com>
	<560EAE6B.2040708@redhat.com>
	<20151003193154-mutt-send-email-mst@redhat.com>
	<CAFEAcA-8qjK3uuFEcAHRkiwYKVkwjN8KWWqEVpuaaa40tjYAwQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-8qjK3uuFEcAHRkiwYKVkwjN8KWWqEVpuaaa40tjYAwQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL 12/22] vhost: rename VHOST_RESET_OWNER to
 VHOST_RESET_DEVICE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, Nov 05, 2015 at 11:42:15AM +0000, Peter Maydell wrote:
> On 3 October 2015 at 17:33, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Fri, Oct 02, 2015 at 06:18:51PM +0200, Paolo Bonzini wrote:
> >>
> >>
> >> On 24/09/2015 15:20, Michael S. Tsirkin wrote:
> >> > From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >> >
> >> > Quote from Michael:
> >> >
> >> >     We really should rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE.
> >>
> >> Where is the corresponding Linux patch for this?
> >>
> >> I would like to fetch the updated headers for KVM, and this is breaking
> >> it.  In fact, a patch that just renames the #define (without providing
> >> the old name for backwards compatibility) would be NACKed in upstream Linux.
> >>
> >> Paolo
> >
> > Right. And it turns out this whole approach is wrong.  I intend to
> > revert this patch, and also drop the patch sending VHOST_RESET_OWNER on
> > device stop.
> 
> This revert doesn't seem to have happened, I think, which means
> that this is one of the things which prevents a clean header-update
> against kvm/next. Could we get this fixed for rc0, please?

My bad. I will fix it next week. What's the deadline for rc0 then?

BTW, as Michael stated, a simple revert is not enough.

	--yliu