From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvi6P-0000RV-VG for qemu-devel@nongnu.org; Mon, 09 Nov 2015 03:47:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvi6O-0003Tf-Nu for qemu-devel@nongnu.org; Mon, 09 Nov 2015 03:47:01 -0500 Date: Mon, 9 Nov 2015 19:47:31 +1100 From: David Gibson Message-ID: <20151109084731.GH18558@voom.redhat.com> References: <1447051637-45246-1-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Hlh2aiwFLCZwGcpw" Content-Disposition: inline In-Reply-To: <1447051637-45246-1-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu] spapr: Add /system-id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --Hlh2aiwFLCZwGcpw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote: > Section B.6.2.1 Root Node Properties of PAPR specification defines > a set of properties which shall be present in the device tree root, > one of these properties is "system-id" which "should be unique across > all systems and all manufacturers". Since UUID is meant to be unique, > it makes sense to use it as "system-id". >=20 > This adds "system-id" property to the device tree root when not empty. >=20 > Signed-off-by: Alexey Kardashevskiy > --- >=20 > This might be expected by AIX so here is the patch. > I am really not sure if it makes sense to initialize property when > UUID is all zeroes as the requirement is "unique" and zero-uuid is > not. Yeah, I think it would be better to omit system-id entirely when a UUID hasn't been supplied. >=20 > --- > hw/ppc/spapr.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index de77528..e8b407d 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -374,6 +374,9 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base, > qemu_uuid[14], qemu_uuid[15]); > =20 > _FDT((fdt_property_string(fdt, "vm,uuid", buf))); > + if (qemu_uuid_set) { > + _FDT((fdt_property_string(fdt, "system-id", buf))); > + } > g_free(buf); > =20 > if (qemu_get_vm_name()) { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Hlh2aiwFLCZwGcpw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWQF2jAAoJEGw4ysog2bOSAV0P/RzM2xY9FZ61UcR5lof9kUNe iu79XnPai/dutsW883zbWBya9LflL23KGoWBwAXQxkakAJazxCLpdlV3sGZMq357 B9nenupUu4E4cL4B9+r3Ks+qnZtn+RW+Hs3IiApTarPIC1mPOaxByBmk5sm4W8TE Tu81xKSKytscwH1E3JPzWhul6AY7snyglkw54+xx+sHYbsZwtUgtWOWkfYIZgvsC v99AgEz14MEw6GF2it/VPXf47x1G/d2/+iKH+wzj5Lo6gduRaxczcJ6402Hhlf0X PzD7yXycLZv2TzJ+Q7nYnzpwEXrYWDra9/gPAyL+ufW2EKjll2lOX7xU+lLUrban Bt2idESVc/YjlytZVTQifkJanyI4YBtDo+7/BP9JXcBEmJlwW+5kfj0YMpiCvG9D wzVNH2C142rQFnbjhofKCKu7zq/z7ZUifFywYIVOq/DKXZEy6B3Po4EehAt5hnEV 7qg6flyq1shftPqbVcHBm7roYGvbSGD3maiwj4/JH1YXHw3LZC5O8jHPEHpZLh54 7HAPtUT/4GS0Irl5faMVspUsPOhl45EpdA8xr/yrzG85LN/tCqlpIxMgzJxUsgx+ QZe9jAB8jrh5xqJBRAkCYqfR8on1ImOa0DmVqVYTLNSfKl7ge6eQalzXX4cNXzZ7 f5EFK7SrocNalXCO39G5 =j6F2 -----END PGP SIGNATURE----- --Hlh2aiwFLCZwGcpw--