From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvjsm-0005ZQ-3h for qemu-devel@nongnu.org; Mon, 09 Nov 2015 05:41:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvjsh-0006Fk-0r for qemu-devel@nongnu.org; Mon, 09 Nov 2015 05:41:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvjsg-0006Fg-RW for qemu-devel@nongnu.org; Mon, 09 Nov 2015 05:40:58 -0500 Date: Mon, 9 Nov 2015 12:40:52 +0200 From: "Michael S. Tsirkin" Message-ID: <20151109124017-mutt-send-email-mst@redhat.com> References: <1446184587-142784-1-git-send-email-guangrong.xiao@linux.intel.com> <1446184587-142784-13-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446184587-142784-13-git-send-email-guangrong.xiao@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v6 12/33] pc-dimm: remove DEFAULT_PC_DIMMSIZE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Fri, Oct 30, 2015 at 01:56:06PM +0800, Xiao Guangrong wrote: > It's not used any more > > Signed-off-by: Xiao Guangrong You should leave the renames and cleanups off for later. This patchset is large enough as it is. > --- > include/hw/mem/pc-dimm.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h > index d83bf30..11a8937 100644 > --- a/include/hw/mem/pc-dimm.h > +++ b/include/hw/mem/pc-dimm.h > @@ -20,8 +20,6 @@ > #include "sysemu/hostmem.h" > #include "hw/qdev.h" > > -#define DEFAULT_PC_DIMMSIZE (1024*1024*1024) > - > #define TYPE_PC_DIMM "pc-dimm" > #define PC_DIMM(obj) \ > OBJECT_CHECK(PCDIMMDevice, (obj), TYPE_PC_DIMM) > -- > 1.8.3.1