From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvovy-0004J5-7g for qemu-devel@nongnu.org; Mon, 09 Nov 2015 11:04:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvovx-0006hA-BI for qemu-devel@nongnu.org; Mon, 09 Nov 2015 11:04:42 -0500 Date: Mon, 9 Nov 2015 17:04:32 +0100 From: Kevin Wolf Message-ID: <20151109160432.GF3621@noname.redhat.com> References: <1446663467-22485-1-git-send-email-mreitz@redhat.com> <1446663467-22485-5-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446663467-22485-5-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 04/15] iotests: Move _filter_nbd into common.filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Alberto Garcia , qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini Am 04.11.2015 um 19:57 hat Max Reitz geschrieben: > _filter_nbd can be useful for other NBD tests, too, therefore it should > reside in common.filter, and it should support URLs of the "nbd://" > format and export names. > > The NBD log lines ("/your/source/dir/nbd.c:function():line: error") > should not be converted to empty lines but removed altogether. > > Signed-off-by: Max Reitz Code motion and modification in the same patch is bad style. The changes look good, though. Kevin