From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvtKf-0005CN-93 for qemu-devel@nongnu.org; Mon, 09 Nov 2015 15:46:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvtKb-0005cD-7u for qemu-devel@nongnu.org; Mon, 09 Nov 2015 15:46:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvtKb-0005c9-30 for qemu-devel@nongnu.org; Mon, 09 Nov 2015 15:46:25 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C34D08F28A for ; Mon, 9 Nov 2015 20:46:24 +0000 (UTC) Date: Mon, 9 Nov 2015 22:46:21 +0200 From: "Michael S. Tsirkin" Message-ID: <20151109224539-mutt-send-email-mst@redhat.com> References: <1446233769-7892-1-git-send-email-ehabkost@redhat.com> <56374F1B.6010904@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56374F1B.6010904@redhat.com> Subject: Re: [Qemu-devel] [PATCH RESEND v2 0/3] pc: Set hw_version on all machine classes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Marcel Apfelbaum , Laszlo Ersek , Eduardo Habkost , qemu-devel@nongnu.org On Mon, Nov 02, 2015 at 12:55:07PM +0100, Paolo Bonzini wrote: > > > On 30/10/2015 20:36, Eduardo Habkost wrote: > > In 2012, QEMU had a bug where it exposed QEMU version information > > to the guest, meaning a QEMU upgrade would expose different > > hardware to the guest OS even if the same machine-type is being > > used. > > > > The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4, > > on all machines up to pc-1.0. But we kept introducing the same > > bug on all newer machines since then. That means we are breaking > > guest ABI every time QEMU was upgraded. > > > > Fix this by setting the hw_version on all PC machines, making > > sure the hardware won't change when upgrading QEMU. > > > > Eduardo Habkost (3): > > pc: Set hw_version on all machine classes > > osdep: Rename qemu_{get,set}_version() to qemu_{,set_}hw_version() > > megasas: Use qemu_hw_version() instead of QEMU_VERSION > > > > hw/arm/nseries.c | 2 +- > > hw/i386/pc_piix.c | 13 +++++++++++++ > > hw/i386/pc_q35.c | 10 ++++++++++ > > hw/ide/core.c | 2 +- > > hw/scsi/megasas.c | 2 +- > > hw/scsi/scsi-bus.c | 2 +- > > hw/scsi/scsi-disk.c | 2 +- > > include/qemu/osdep.h | 4 ++-- > > target-i386/cpu.c | 2 +- > > util/osdep.c | 10 +++++----- > > vl.c | 2 +- > > 11 files changed, 37 insertions(+), 14 deletions(-) > > > > Michael, is it okay for you if I merge this patch series? > > Paolo Sorry about missing this the 1st time around. Let's discuss the right thing to do here - it's a bugfix so we can merge it after hard freeze. -- MST