From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45444)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZwAS1-0001gO-Fp
	for qemu-devel@nongnu.org; Tue, 10 Nov 2015 10:03:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZwAS0-0002E5-8W
	for qemu-devel@nongnu.org; Tue, 10 Nov 2015 10:03:13 -0500
Date: Tue, 10 Nov 2015 16:03:02 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20151110150302.GD4163@noname.redhat.com>
References: <1447164580-31094-1-git-send-email-kwolf@redhat.com>
	<1447164580-31094-40-git-send-email-kwolf@redhat.com>
	<CAJSP0QU=UprDJXDN-AR71oxV9y=srW2uOycpEmcEctgQ+-_gTw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJSP0QU=UprDJXDN-AR71oxV9y=srW2uOycpEmcEctgQ+-_gTw@mail.gmail.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PULL v2 39/40] iotests: Add tests
 for the x-blockdev-del command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Alberto Garcia <berto@igalia.com>, qemu-devel <qemu-devel@nongnu.org>, qemu block <qemu-block@nongnu.org>

Am 10.11.2015 um 15:59 hat Stefan Hajnoczi geschrieben:
> On Tue, Nov 10, 2015 at 2:09 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> > From: Alberto Garcia <berto@igalia.com>
> >
> > Signed-off-by: Alberto Garcia <berto@igalia.com>
> > Message-id: 57c3b0d4d0c73ddadd19e5bded9492c359cc4568.1446475331.git.berto@igalia.com
> > Reviewed-by: Max Reitz <mreitz@redhat.com>
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > ---
> >  tests/qemu-iotests/139     | 414 +++++++++++++++++++++++++++++++++++++++++++++
> >  tests/qemu-iotests/139.out |   5 +
> >  tests/qemu-iotests/group   |   1 +
> >  3 files changed, 420 insertions(+)
> >  create mode 100644 tests/qemu-iotests/139
> >  create mode 100644 tests/qemu-iotests/139.out
> 
> I'm seeing the following failure:
> 
>  ./check -qcow2 139
> QEMU          -- "./qemu" -nodefaults
> QEMU_IMG      -- "./qemu-img"
> QEMU_IO       -- "./qemu-io"  -f qcow2 --cache writeback
> QEMU_NBD      -- "./qemu-nbd"
> IMGFMT        -- qcow2 (compat=1.1)
> IMGPROTO      -- file
> PLATFORM      -- Linux/x86_64 stefanha-x1 4.2.5-300.fc23.x86_64
> TEST_DIR      -- /home/stefanha/qemu/tests/qemu-iotests/scratch
> SOCKET_SCM_HELPER -- /home/stefanha/qemu/tests/qemu-iotests/socket_scm_helper
> 
> 139         [failed, exit status 1] - output mismatch (see 139.out.bad)
> --- /home/stefanha/qemu/tests/qemu-iotests/139.out    2015-11-10
> 14:24:03.728322694 +0000
> +++ 139.out.bad    2015-11-10 14:54:51.617899443 +0000
> @@ -1,5 +1,19 @@
> -............
> +........F...
> +======================================================================
> +FAIL: testQuorum (__main__.TestBlockdevDel)
> +----------------------------------------------------------------------
> +Traceback (most recent call last):
> +  File "139", line 403, in testQuorum
> +    self.addQuorum('quorum0', 'node0', 'node1')
> +  File "139", line 291, in addQuorum
> +    self.assert_qmp(result, 'return', {})
> +  File "/home/stefanha/qemu/tests/qemu-iotests/iotests.py", line 314,
> in assert_qmp
> +    result = self.dictpath(d, path)
> +  File "/home/stefanha/qemu/tests/qemu-iotests/iotests.py", line 293,
> in dictpath
> +    self.fail('failed path traversal for "%s" in "%s"' % (path, str(d)))
> +AssertionError: failed path traversal for "return" in "{u'error':
> {u'class': u'GenericError', u'desc': u"Unknown driver 'quorum'"}}"
> +

I guess we need a follow-up patch for -rc1 that simply skips the test
case if quorum isn't available.

Kevin