From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCCy-0004iV-JT for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:55:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwCCv-0003nX-6z for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:55:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCCu-0003nT-RI for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:55:45 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7D5183B711 for ; Tue, 10 Nov 2015 16:55:44 +0000 (UTC) Date: Tue, 10 Nov 2015 16:55:40 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20151110165540.GF2456@work-vm> References: <1447174381-7171-1-git-send-email-quintela@redhat.com> <1447174381-7171-2-git-send-email-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447174381-7171-2-git-send-email-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] migration: print ram_addr_t as RAM_ADDR_FMT not %zx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: amit.shah@redhat.com, qemu-devel@nongnu.org * Juan Quintela (quintela@redhat.com) wrote: > Not all the wold is 64bits (yet). > > Signed-off-by: Juan Quintela Yep that's my fault. Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 62cf42b..d8d5a50 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -1184,7 +1184,8 @@ int ram_save_queue_pages(MigrationState *ms, const char *rbname, > } > trace_ram_save_queue_pages(ramblock->idstr, start, len); > if (start+len > ramblock->used_length) { > - error_report("%s request overrun start=%zx len=%zx blocklen=%zx", > + error_report("%s request overrun start=" RAM_ADDR_FMT " len=" > + RAM_ADDR_FMT " blocklen=" RAM_ADDR_FMT, > __func__, start, len, ramblock->used_length); > goto err; > } > @@ -1845,7 +1846,7 @@ int ram_discard_range(MigrationIncomingState *mis, > ret = postcopy_ram_discard_range(mis, host_startaddr, length); > } else { > error_report("ram_discard_range: Overrun block '%s' (%" PRIu64 > - "/%zu/%zu)", > + "/%zx/" RAM_ADDR_FMT")", > block_name, start, length, rb->used_length); > } > > -- > 2.5.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK