From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCDj-0005c7-8M for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:56:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwCDg-0003u5-0j for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:56:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwCDf-0003tv-S8 for qemu-devel@nongnu.org; Tue, 10 Nov 2015 11:56:31 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 83EDC935F0 for ; Tue, 10 Nov 2015 16:56:31 +0000 (UTC) Date: Tue, 10 Nov 2015 16:56:27 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20151110165627.GG2456@work-vm> References: <1447174381-7171-1-git-send-email-quintela@redhat.com> <1447174381-7171-3-git-send-email-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447174381-7171-3-git-send-email-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] migration: Make 32bit linux compile with RDMA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: amit.shah@redhat.com, qemu-devel@nongnu.org * Juan Quintela (quintela@redhat.com) wrote: > Rest of the file already use that trick. 64bit offsets make no sense in > 32bit archs, but that is ram_addr_t for you. > > Signed-off-by: Juan Quintela > --- > migration/rdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/rdma.c b/migration/rdma.c > index 553fbd7..dcabb91 100644 > --- a/migration/rdma.c > +++ b/migration/rdma.c > @@ -577,7 +577,7 @@ static int rdma_add_block(RDMAContext *rdma, const char *block_name, > block->is_ram_block = local->init ? false : true; > > if (rdma->blockmap) { > - g_hash_table_insert(rdma->blockmap, (void *) block_offset, block); > + g_hash_table_insert(rdma->blockmap, (void *)(uintptr_t)block_offset, block); Reviewed-by: Dr. David Alan Gilbert Dave > } > > trace_rdma_add_block(block_name, local->nb_blocks, > -- > 2.5.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK