From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwL7n-0004JY-19 for qemu-devel@nongnu.org; Tue, 10 Nov 2015 21:27:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwL7j-0001Jm-5S for qemu-devel@nongnu.org; Tue, 10 Nov 2015 21:27:02 -0500 Date: Wed, 11 Nov 2015 13:11:59 +1100 From: David Gibson Message-ID: <20151111021159.GE5852@voom.redhat.com> References: <1445608598-24485-1-git-send-email-mark.cave-ayland@ilande.co.uk> <56339F4C.6070302@ilande.co.uk> <20151104034413.GN21954@voom.redhat.com> <563A9572.5000104@ilande.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dzs2zDY0zgkG72+7" Content-Disposition: inline In-Reply-To: <563A9572.5000104@ilande.co.uk> Subject: Re: [Qemu-devel] [PATCH 00/13] Mac OS 9 compatibility improvements (upstream rework) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: agraf@suse.de, qemu-ppc@nongnu.org, cormac@c-obrien.org, qemu-devel@nongnu.org --Dzs2zDY0zgkG72+7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 04, 2015 at 11:32:02PM +0000, Mark Cave-Ayland wrote: > On 04/11/15 03:44, David Gibson wrote: >=20 > > On Fri, Oct 30, 2015 at 04:48:12PM +0000, Mark Cave-Ayland wrote: > >> On 23/10/15 14:56, Mark Cave-Ayland wrote: > >> > >>> This is a rework of Cormac O'Brien's GSoC project to try and boot Mac= OS 9 under > >>> QEMU, the original version of which was posted to the qemu-devel list= at the > >>> end of August (https://lists.gnu.org/archive/html/qemu-devel/2015-08/= msg02521.html). > >>> > >>> The patchset consisted of some simple patches from Alex and then a la= rge set of > >>> CUDA changes supplied as a single patch which were the result of Corm= ac analysing > >>> MOL with Alex's help to try and further the boot process. > >>> > >>> In their previous form, the patches were unsuitable for applying upst= ream since > >>> while they furthered MacOS 9 boot, they also caused a couple of major= regressions > >>> such as breaking the mouse and causing Darwin/OS X boot to panic on s= tartup. > >>> > >>> This reworked patchset fixes these regressions, includes some other c= lean-ups=20 > >>> and more importantly now passes all of my OpenBIOS image boot tests w= ith an=20 > >>> OpenBIOS binary from SVN trunk (separate pull request to be sent shor= tly). > >>> Whilst OpenBIOS still needs one additional patch to run the MacOS 9 b= ootloader, > >>> I've uploaded a pre-compiled binary to=20 > >>> https://www.ilande.co.uk/tmp/openbios-ppc for people interested in te= sting the=20 > >>> new MacOS 9 functionality. > >>> > >>> Apologies for the delay in sending this out on-list, however due to r= ecent > >>> circumstances I've been without a reliable broadband connection for a= couple > >>> of weeks. However given that this is mostly a rework of the previous = patchset=20 > >>> and looks good in testing here, I'd definitely like it to be consider= ed for > >>> application during soft freeze. > >>> > >>> Signed-off-by: Mark Cave-Ayland > >>> > >>> Alexander Graf (3): > >>> PPC: Allow Rc bit to be set on mtspr > >>> PPC: Fix lsxw bounds checks > >>> PPC: mac99: Always add USB controller > >>> > >>> Mark Cave-Ayland (10): > >>> cuda.c: fix CUDA ADB error packet format > >>> cuda.c: fix CUDA_PACKET response packet format > >>> cuda.c: implement simple CUDA_GET_6805_ADDR command > >>> cuda.c: implement dummy IIC access commands > >>> cuda.c: fix CUDA SR interrupt clearing > >>> cuda.c: add defines for CUDA registers > >>> cuda.c: refactor get_tb() so that the time can be passed in > >>> cuda.c: rename get_counter() state variable from s to ti for > >>> consistency > >>> cuda.c: fix T2 timer and enable its interrupt > >>> cuda.c: add delay to setting of SR_INT bit > >>> > >>> hw/misc/macio/cuda.c | 243 ++++++++++++++++++++++++++++++-------= ---------- > >>> hw/ppc/mac.h | 3 + > >>> hw/ppc/mac_newworld.c | 3 +- > >>> target-ppc/mem_helper.c | 5 +- > >>> target-ppc/translate.c | 2 +- > >>> 5 files changed, 163 insertions(+), 93 deletions(-) > >> > >> Ping? Can anyone review this in Alex's absence? In the meantime I've > >> added it to wiki at http://wiki.qemu.org/Planning/2.5 as it would be > >> good to get the GSoC work upstream for 2.5. > >=20 > > Sorry I've taken a while to get to this. It looks pretty good, though > > I've sent a handful of comments on individual patches. > >=20 > > I gathered from one of your replies that you do intend to do a > > respin. The current comments all look pretty trivial, so I expect > > I'll be ok to apply your respin to ppc-next (which I'm looking after > > in agraf's absence). It would be nice to get a review from someone > > more familiar with, or better able to test MacOS stuff. >=20 > Great. I've sent a further few replies, so if you're happy with the > answers let me know and I'll send a v2 tomorrow. Haven't seen v2. Did something sidetrack you, or did I manage to miss it? >=20 > In terms of testing, as I mentioned above it doesn't regress any of my > working OpenBIOS test-suite images which is a good sign. I'm not sure > who else would be able to review the MacOS side. Both Segher and Ben. H > have looked at parts of the original code changes during GSoC, although > that was from a debugging rather than a code review perspective. >=20 >=20 > ATB, >=20 > Mark. >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Dzs2zDY0zgkG72+7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWQqPuAAoJEGw4ysog2bOShJcQAK9Zhdpbyp/RU61WkJpZIzIW 9j9pEEznqfrnZgaOHEanjlDAn+xKGjITyKJj0DaUSjnAJCLKdX1XCbN1gTDFinaM uqXQG3VDRzW/0a7cngid9UQQbVGmxFtQEGG8BKAAey9wbs+EYil1ZILVCVoGppca 6f1KaaOgSK7dTMjCPX7S8cEcVu8JCNM4pHpO4cuFtFZ69BiKC1Tyg19P96959mPl BkUcxanP2tm0+A80/KKq6FgtbCnlmJXjvD14Ww4BLagXmDkaABdLZEQmsWnsxSzz HGZH8NQnI40d9AnRh+zmbllOebrcxdIZqKZAmGzSnq6i8J5kTXzjBQLI8w9ojjgE btdzgDp81VRMVSzjK8Sc4Qoy04rcw/029yfXy2dg1u3BxBwCDvVOndg409A/xFS7 KLZbiitHdxKY2Ik6rsp9dgM8EneLoKKDxA7qXk8x3qvHlvBGMrX6lEnNldmlRaV1 Z+BP3Vb+Lb+gApeNN1OfMtcdPkbjS8d1+o8qTEQ3I/q2DY8Joun+YdokhHcRVrSV rTq5Y4kdQMW3bquJgUFcpZQsGgeyi72+mKThhDYvKd/0md4s9XNvKWaXCxqQUpGv ic/W2LJwcz/dcpEdaOoZKThVP58Tg4gzQNGfmN54zQCP/KwnzOQnBVPpDM1kWMux h3n3i7EqBwRZKzWIRVdb =s/B5 -----END PGP SIGNATURE----- --Dzs2zDY0zgkG72+7--