From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwPzB-0000vP-5D for qemu-devel@nongnu.org; Wed, 11 Nov 2015 02:38:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwPz9-0007Tl-Mf for qemu-devel@nongnu.org; Wed, 11 Nov 2015 02:38:29 -0500 Date: Wed, 11 Nov 2015 17:52:20 +1100 From: David Gibson Message-ID: <20151111065220.GG5852@voom.redhat.com> References: <1445608598-24485-1-git-send-email-mark.cave-ayland@ilande.co.uk> <56339F4C.6070302@ilande.co.uk> <20151104034413.GN21954@voom.redhat.com> <563A9572.5000104@ilande.co.uk> <20151111021159.GE5852@voom.redhat.com> <5642E035.7030005@ilande.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GUPx2O/K0ibUojHx" Content-Disposition: inline In-Reply-To: <5642E035.7030005@ilande.co.uk> Subject: Re: [Qemu-devel] [PATCH 00/13] Mac OS 9 compatibility improvements (upstream rework) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de, cormac@c-obrien.org --GUPx2O/K0ibUojHx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 11, 2015 at 06:29:09AM +0000, Mark Cave-Ayland wrote: > On 11/11/15 02:11, David Gibson wrote: >=20 > > On Wed, Nov 04, 2015 at 11:32:02PM +0000, Mark Cave-Ayland wrote: > >> On 04/11/15 03:44, David Gibson wrote: > >> > >>> On Fri, Oct 30, 2015 at 04:48:12PM +0000, Mark Cave-Ayland wrote: > >>>> On 23/10/15 14:56, Mark Cave-Ayland wrote: > >>>> > >>>>> This is a rework of Cormac O'Brien's GSoC project to try and boot M= acOS 9 under > >>>>> QEMU, the original version of which was posted to the qemu-devel li= st at the > >>>>> end of August (https://lists.gnu.org/archive/html/qemu-devel/2015-0= 8/msg02521.html). > >>>>> > >>>>> The patchset consisted of some simple patches from Alex and then a = large set of > >>>>> CUDA changes supplied as a single patch which were the result of Co= rmac analysing > >>>>> MOL with Alex's help to try and further the boot process. > >>>>> > >>>>> In their previous form, the patches were unsuitable for applying up= stream since > >>>>> while they furthered MacOS 9 boot, they also caused a couple of maj= or regressions > >>>>> such as breaking the mouse and causing Darwin/OS X boot to panic on= startup. > >>>>> > >>>>> This reworked patchset fixes these regressions, includes some other= clean-ups=20 > >>>>> and more importantly now passes all of my OpenBIOS image boot tests= with an=20 > >>>>> OpenBIOS binary from SVN trunk (separate pull request to be sent sh= ortly). > >>>>> Whilst OpenBIOS still needs one additional patch to run the MacOS 9= bootloader, > >>>>> I've uploaded a pre-compiled binary to=20 > >>>>> https://www.ilande.co.uk/tmp/openbios-ppc for people interested in = testing the=20 > >>>>> new MacOS 9 functionality. > >>>>> > >>>>> Apologies for the delay in sending this out on-list, however due to= recent > >>>>> circumstances I've been without a reliable broadband connection for= a couple > >>>>> of weeks. However given that this is mostly a rework of the previou= s patchset=20 > >>>>> and looks good in testing here, I'd definitely like it to be consid= ered for > >>>>> application during soft freeze. > >>>>> > >>>>> Signed-off-by: Mark Cave-Ayland > >>>>> > >>>>> Alexander Graf (3): > >>>>> PPC: Allow Rc bit to be set on mtspr > >>>>> PPC: Fix lsxw bounds checks > >>>>> PPC: mac99: Always add USB controller > >>>>> > >>>>> Mark Cave-Ayland (10): > >>>>> cuda.c: fix CUDA ADB error packet format > >>>>> cuda.c: fix CUDA_PACKET response packet format > >>>>> cuda.c: implement simple CUDA_GET_6805_ADDR command > >>>>> cuda.c: implement dummy IIC access commands > >>>>> cuda.c: fix CUDA SR interrupt clearing > >>>>> cuda.c: add defines for CUDA registers > >>>>> cuda.c: refactor get_tb() so that the time can be passed in > >>>>> cuda.c: rename get_counter() state variable from s to ti for > >>>>> consistency > >>>>> cuda.c: fix T2 timer and enable its interrupt > >>>>> cuda.c: add delay to setting of SR_INT bit > >>>>> > >>>>> hw/misc/macio/cuda.c | 243 ++++++++++++++++++++++++++++++-----= ------------ > >>>>> hw/ppc/mac.h | 3 + > >>>>> hw/ppc/mac_newworld.c | 3 +- > >>>>> target-ppc/mem_helper.c | 5 +- > >>>>> target-ppc/translate.c | 2 +- > >>>>> 5 files changed, 163 insertions(+), 93 deletions(-) > >>>> > >>>> Ping? Can anyone review this in Alex's absence? In the meantime I've > >>>> added it to wiki at http://wiki.qemu.org/Planning/2.5 as it would be > >>>> good to get the GSoC work upstream for 2.5. > >>> > >>> Sorry I've taken a while to get to this. It looks pretty good, though > >>> I've sent a handful of comments on individual patches. > >>> > >>> I gathered from one of your replies that you do intend to do a > >>> respin. The current comments all look pretty trivial, so I expect > >>> I'll be ok to apply your respin to ppc-next (which I'm looking after > >>> in agraf's absence). It would be nice to get a review from someone > >>> more familiar with, or better able to test MacOS stuff. > >> > >> Great. I've sent a further few replies, so if you're happy with the > >> answers let me know and I'll send a v2 tomorrow. > >=20 > > Haven't seen v2. Did something sidetrack you, or did I manage to miss > > it? >=20 > Hi David, >=20 > I am still waiting for feedback (and Reviewed-by tags) for a few replies > to your initial patch review: >=20 > https://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00855.html > https://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00856.html > https://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg00862.html Sorry, I managed to miss these. The first two replies seem good, I'll send a few comments on the third now. > In particular would you like me to add the comments about MOL to the > commit messages? But yes, referencing MOL in the messages would be good so we can see where this came from in the future. > And I wasn't sure from your comments whether you were > still looking for someone else more able to test the MacOS stuff? Well, that would be nice, but in the absence of any volunteers, I'll take the series anyway (provided I don't spot breakage of other platforms, obviously). > That said, if you're happy with my responses I can respin later today if > you are able to send a pull request before tomorrow (which is when > freeze hits)? I have enough free time over the next couple of weeks to > handle any issues that may arise, although I'm fairly confident in these > patches as I've been running them locally over my OpenBIOS test images > for a few weeks now. >=20 >=20 > ATB, >=20 > Mark. >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GUPx2O/K0ibUojHx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWQuWkAAoJEGw4ysog2bOSxn4QAMF98NVQ1ywgDiKG55xCumqy D+duycq8raA0IF4gHiyFUiKJ6MjoOBL9lo956RIM5vHVJ8K8K9praXZV203AT2AZ CuBDpgfDQ+o0JyU0AndPlkH8kQ+ulr2+QPj0WoOOShCFAq+TWxEI3oYf/9FEf67L APK2lrj9qUx3QdYBpUqJXDQrEzkgZpuX6O15M/u2048aHzbaik/N8IvUTVG/loIL vCxI+bGFFV8ShwRLDtWO8xkWwLfMPyHZlSwbp36/LytOlrNSw7RuEeSdQGSEE6o1 5PhvLPyxjn/k5Do2U8VxkGz9iX2ujsdn5MCx8/JO2uPnSL3pLotpjUKbwuSAoFoW vRRVREukFpNIilYB7YNn1/8G70//HQfNIAHl6JcgFXt26ixvdLa3Sg+BJChdy4MW GHEbY1hMxwA6HB800y8Z1ZGE2pVvvA+WqDT3Jzr6iewNtdLSg7YikiFbSmLBbUqA T/cepqXrfOfpe+5x82DU6BlkYNLmxIX9DJIJ2+8B5qh23dcq6x8yUrQRiyOHXJYY eKbWqZI6wPYwOcBAjy0Umtx60qbYBMz/Nyn9FHJIKsaYk8OYHEpWvPyLK99pSjQc yItwnmZuf4X2lZUmG3di4g804qwqB8BpXPG/vZxrvdM9mi7WnQoNqTyNrASA085G 61j0n7ikMSG3gOrUPLFE =lo6Q -----END PGP SIGNATURE----- --GUPx2O/K0ibUojHx--