From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-trivial@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Richard Henderson <rth@twiddle.net>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous return statements
Date: Wed, 11 Nov 2015 12:25:03 +0100 [thread overview]
Message-ID: <20151111122503.1e445227.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1447186571-27672-4-git-send-email-thuth@redhat.com>
On Tue, 10 Nov 2015 21:16:10 +0100
Thomas Huth <thuth@redhat.com> wrote:
> The "return;" statements at the end of functions do not make
> much sense, so let's remove them.
>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/s390x/css.c | 1 -
> hw/s390x/event-facility.c | 21 ++++++---------------
> hw/s390x/s390-pci-bus.c | 4 ----
> 3 files changed, 6 insertions(+), 20 deletions(-)
>
Ack for the css and pci parts.
The sclp parts, however, switch from "one point of exit" to "immediate
exit", and I'm not sure I like that; not sure enough anyway to apply
this patch.
next prev parent reply other threads:[~2015-11-11 11:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 20:16 [Qemu-devel] [PATCH 0/4] Remove superfluous return statements Thomas Huth
2015-11-10 20:16 ` [Qemu-devel] [PATCH 1/4] hw/ide: " Thomas Huth
2015-11-10 20:17 ` John Snow
2015-11-10 20:16 ` [Qemu-devel] [PATCH 2/4] hw/acpi: Remove superfluous return statement Thomas Huth
2015-11-10 20:16 ` [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous return statements Thomas Huth
2015-11-11 11:25 ` Cornelia Huck [this message]
2015-11-11 13:29 ` Thomas Huth
2015-11-10 20:16 ` [Qemu-devel] [PATCH 4/4] hw/core/qdev: Remove superfluous return statement Thomas Huth
2016-01-11 8:29 ` [Qemu-devel] [PATCH 0/4] Remove superfluous return statements Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111122503.1e445227.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).