From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51179)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZwlA4-000377-PH
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 01:15:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZwlA3-0006qo-Ur
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 01:15:08 -0500
Date: Thu, 12 Nov 2015 14:14:56 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151112061456.GA4082@ad.usersys.redhat.com>
References: <1447108773-6836-1-git-send-email-mreitz@redhat.com>
	<1447108773-6836-2-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447108773-6836-2-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 01/24] blockdev: Add missing
 bdrv_unref() in drive-backup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>

On Mon, 11/09 23:39, Max Reitz wrote:
> All error paths after a successful bdrv_open() of target_bs should
> contain a bdrv_unref(target_bs). This one did not yet, so add it.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  blockdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/blockdev.c b/blockdev.c
> index 8607df9..3185808 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2914,6 +2914,7 @@ void qmp_drive_backup(const char *device, const char *target,
>          bmap = bdrv_find_dirty_bitmap(bs, bitmap);
>          if (!bmap) {
>              error_setg(errp, "Bitmap '%s' could not be found", bitmap);
> +            bdrv_unref(target_bs);
>              goto out;
>          }
>      }
> -- 
> 2.6.2
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>