From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwnFD-0005N8-LV for qemu-devel@nongnu.org; Thu, 12 Nov 2015 03:28:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwnF9-0000md-L9 for qemu-devel@nongnu.org; Thu, 12 Nov 2015 03:28:35 -0500 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:57690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwnF9-0000mO-9K for qemu-devel@nongnu.org; Thu, 12 Nov 2015 03:28:31 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Nov 2015 08:28:27 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3FA541B0804B for ; Thu, 12 Nov 2015 08:28:43 +0000 (GMT) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tAC8SPSL3277092 for ; Thu, 12 Nov 2015 08:28:25 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tAC8SPxR015027 for ; Thu, 12 Nov 2015 01:28:25 -0700 Date: Thu, 12 Nov 2015 09:28:21 +0100 From: Greg Kurz Message-ID: <20151112092821.14799fbb@bahia.local> In-Reply-To: <20151022171252.15633.54658.stgit@bahia.huguette.org> References: <20151022171252.15633.54658.stgit@bahia.huguette.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-9p: add savem handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aneesh.kumar@linux.vnet.ibm.com, "Michael S. Tsirkin" On Thu, 22 Oct 2015 19:38:42 +0200 Greg Kurz wrote: > We don't support migration of mounted 9p shares. This is handled by a > migration blocker. > > One would expect, however, to be able to migrate if the share is unmounted. > Unfortunately virtio-9p-device does not register savevm handlers at all ! > Migration succeeds and leaves the guest with a dangling device... > > This patch simply registers migration handlers for virtio-9p-device. Whether > migration is possible or not still depends on the migration blocker. > > Signed-off-by: Greg Kurz > --- Ping ? > Michael, Aneesh, > > This is the same patch minus the call to unregister_savevm() since we don't > have an unrealize handler. > > I decided to simply drop all the other patches. Hot-unplug support is totally > missing and definitely needs more work. I'll try to come up with a solution > in its own series. > > Cheers. > > -- > Greg > > --- > hw/9pfs/virtio-9p-device.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > index 93a407c45926..e3abcfaffb2a 100644 > --- a/hw/9pfs/virtio-9p-device.c > +++ b/hw/9pfs/virtio-9p-device.c > @@ -43,6 +43,16 @@ static void virtio_9p_get_config(VirtIODevice *vdev, uint8_t *config) > g_free(cfg); > } > > +static void virtio_9p_save(QEMUFile *f, void *opaque) > +{ > + virtio_save(VIRTIO_DEVICE(opaque), f); > +} > + > +static int virtio_9p_load(QEMUFile *f, void *opaque, int version_id) > +{ > + return virtio_load(VIRTIO_DEVICE(opaque), f, version_id); > +} > + > static void virtio_9p_device_realize(DeviceState *dev, Error **errp) > { > VirtIODevice *vdev = VIRTIO_DEVICE(dev); > @@ -130,6 +140,7 @@ static void virtio_9p_device_realize(DeviceState *dev, Error **errp) > } > v9fs_path_free(&path); > > + register_savevm(dev, "virtio-9p", -1, 1, virtio_9p_save, virtio_9p_load, s); > return; > out: > g_free(s->ctx.fs_root); > >