Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote:
> nseries doesn't use qemu_set_hw_version() and doesn't need the
> compatibility magic of qemu_hw_version(). Use QEMU_VERSION
> directly.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

This looks very wrong.
We should be reducing the users of QEMU_VERSION,
not adding more.


> ---
>  hw/arm/nseries.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
> index 2a8835e..f1eab73 100644
> --- a/hw/arm/nseries.c
> +++ b/hw/arm/nseries.c
> @@ -1275,7 +1275,7 @@ static int n8x0_atag_setup(void *p, int model)
>      strcpy((void *) w, "hw-build");		/* char component[12] */
>      w += 6;
>      strcpy((void *) w, "QEMU ");
> -    pstrcat((void *) w, 12, qemu_hw_version()); /* char version[12] */
> +    pstrcat((void *) w, 12, QEMU_VERSION); /* char version[12] */
>      w += 6;
>  
>      tag = (model == 810) ? "1.1.10-qemu" : "1.1.6-qemu";
> -- 
> 2.1.0