[Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

[Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

[Eduardo Habkost]

nseries doesn't use qemu_set_hw_version() and doesn't need the
compatibility magic of qemu_hw_version(). Use QEMU_VERSION
directly.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/arm/nseries.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index 2a8835e..f1eab73 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -1275,7 +1275,7 @@ static int n8x0_atag_setup(void *p, int model)
     strcpy((void *) w, "hw-build");		/* char component[12] */
     w += 6;
     strcpy((void *) w, "QEMU ");
-    pstrcat((void *) w, 12, qemu_hw_version()); /* char version[12] */
+    pstrcat((void *) w, 12, QEMU_VERSION); /* char version[12] */
     w += 6;
 
     tag = (model == 810) ? "1.1.10-qemu" : "1.1.6-qemu";
-- 
2.1.0

Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

[Michael S. Tsirkin]

On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote:
> nseries doesn't use qemu_set_hw_version() and doesn't need the
> compatibility magic of qemu_hw_version(). Use QEMU_VERSION
> directly.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

This looks very wrong.
We should be reducing the users of QEMU_VERSION,
not adding more.


> ---
>  hw/arm/nseries.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
> index 2a8835e..f1eab73 100644
> --- a/hw/arm/nseries.c
> +++ b/hw/arm/nseries.c
> @@ -1275,7 +1275,7 @@ static int n8x0_atag_setup(void *p, int model)
>      strcpy((void *) w, "hw-build");		/* char component[12] */
>      w += 6;
>      strcpy((void *) w, "QEMU ");
> -    pstrcat((void *) w, 12, qemu_hw_version()); /* char version[12] */
> +    pstrcat((void *) w, 12, QEMU_VERSION); /* char version[12] */
>      w += 6;
>  
>      tag = (model == 810) ? "1.1.10-qemu" : "1.1.6-qemu";
> -- 
> 2.1.0

Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

[Eduardo Habkost]

On Thu, Nov 12, 2015 at 01:39:24PM +0200, Michael S. Tsirkin wrote:
> On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote:
> > nseries doesn't use qemu_set_hw_version() and doesn't need the
> > compatibility magic of qemu_hw_version(). Use QEMU_VERSION
> > directly.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> 
> This looks very wrong.
> We should be reducing the users of QEMU_VERSION,
> not adding more.

I would like to hear from the users and maintainers of the
nseries machines, to judge this. I assume they don't need ABI
compatibility betweeen QEMU versions, and maybe they want to know
the QEMU version they are running.

-- 
Eduardo

Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

[Peter Maydell]

On 12 November 2015 at 15:04, Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Thu, Nov 12, 2015 at 01:39:24PM +0200, Michael S. Tsirkin wrote:
>> On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote:
>> > nseries doesn't use qemu_set_hw_version() and doesn't need the
>> > compatibility magic of qemu_hw_version(). Use QEMU_VERSION
>> > directly.
>> >
>> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>
>> This looks very wrong.
>> We should be reducing the users of QEMU_VERSION,
>> not adding more.
>
> I would like to hear from the users and maintainers of the
> nseries machines, to judge this. I assume they don't need ABI
> compatibility betweeen QEMU versions, and maybe they want to know
> the QEMU version they are running.

I suspect you won't find many users or maintainers on this
list (or anywhere else). My guess is that this was useful
for when Nokia were actively shipping an SDK that used QEMU
(because then they could surface the QEMU and other component
version information to SDK end-users and get better bug reports
and so on as a result), but that anybody still using upstream
QEMU to emulate an n-series device is capable of reporting
what QEMU version they're using without having to have it
reported via a dialog box inside the guest :-)

thanks
-- PMM