From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZwqV8-0000v2-7E
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 06:57:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZwqV3-0002fe-8Q
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 06:57:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZwqV3-0002fD-3j
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 06:57:09 -0500
Date: Thu, 12 Nov 2015 13:57:04 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151112135643-mutt-send-email-mst@redhat.com>
References: <1447251876-4811-1-git-send-email-victork@redhat.com>
	<CAJ+F1CLyoNkT1z6_=SCiC_QyKVXgUJKMr4GKzEW4gq-dwKCH7A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAJ+F1CLyoNkT1z6_=SCiC_QyKVXgUJKMr4GKzEW4gq-dwKCH7A@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass
 mmap size and offset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: Victor Kaplansky <victork@redhat.com>, QEMU <qemu-devel@nongnu.org>

On Wed, Nov 11, 2015 at 04:33:05PM +0100, Marc-Andr=E9 Lureau wrote:
> Hi
>=20
> On Wed, Nov 11, 2015 at 3:26 PM, Victor Kaplansky <victork@redhat.com> =
wrote:
> >
> > -      Sets the logging base address.
> > +      Sets logging shared memory space.
> > +      When slave has VHOST_USER_PROTOCOL_F_LOG_SHMFD protocol
> > +      feature, the log memory fd is provided in the ancillary data o=
f
> > +      VHOST_USER_SET_LOG_BASE message, the size and offset of shared
> > +      memory area provided in the message.
>=20
> I think this extra payload needs a better description, in payload
> description above. Something like
>=20
>  * A pair of 64-bit integers
>    -------------
>    | u64 | u64 |
>    -------------
>=20
>    u64: a 64-bit unsigned integer
>=20
> "the size and offset of shared memory area provided in the message as
> a pair of 64-bit integers."

Sounds good. I've queued this one up, pls tweak docs
with patches on top.

> --=20
> Marc-Andr=E9 Lureau