From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwuFf-0004f6-EH for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:57:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwuFb-0004YB-IG for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:57:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwuFb-0004Y3-CG for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:57:27 -0500 Date: Thu, 12 Nov 2015 15:57:22 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20151112155722.GJ2754@work-vm> References: <20151112120443.GE2754@work-vm> <20151112122318.GF2754@work-vm> <20151112130831.GG2754@work-vm> <20151112142034.GI2754@work-vm> <87lha3qly4.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lha3qly4.fsf@emacs.mitica> Subject: Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Amit Shah , Peter Maydell , QEMU Developers * Juan Quintela (quintela@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Peter Maydell (peter.maydell@linaro.org) wrote: > >> On 12 November 2015 at 13:18, Peter Maydell wrote: > >> > On 12 November 2015 at 13:08, Dr. David Alan Gilbert > >> > wrote: > >> >> OK, can you try a simple migration by hand outside of the test harness; > >> >> just something simple like: > >> >> > >> >> ./bin/qemu-system-x86_64 -M pc -nographic > >> >> (qemu) migrate "exec: cat > /dev/null" > >> >> > >> >> and the same with q35 ? > >> > > >> > (qemu) migrate "exec: cat > /dev/null" > >> > migrate_get_current do init of current_migration 65307 > >> > unqueue_page 65307 > >> > 0 qemu-system-x86_64 0x00000001067c01c3 qemu_mutex_lock + 83 > >> > >> This turns out to be because migrate_init() is corrupting the > >> mutex memory when it does "memset(s, 0, sizeof(*s))". Presumably > >> Linux's initialized-mutex is all-zeroes, but OSX's is not. > > > > OK, thanks for finding that; I've just smoke tested the following > > patch and will post it properly after I test it more thoroughly in > > a couple of hours. > > I did a patch that was almost identical. It is passing for me virt-test. and the one I posted seems to survive postcopy as well; so looks good. Dave > > Later, Juan. -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK