Re: [Qemu-devel] [PATCH v2 1/1] migrate-start-postcopy: Improve text

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Eric Blake (eblake@redhat.com) wrote:
> On 11/12/2015 04:34 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > Improve the text in both the qapi-schema and hmp help to point out
> > you need to set the postcopy-ram capability prior to issuing
> > migrate-start-postcopy.
> > 
> > Also fix the text of the migrate_start_postcopy error that
> > deals with capabilities.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> > v2
> >   Updated text to Erik's suggestion
> 
> It's Eric, but you're not the first (nor the last) to make that typo.

Oops sorry about that.


> > +++ b/qapi-schema.json
> > @@ -706,7 +706,9 @@
> >  ##
> >  # @migrate-start-postcopy
> >  #
> > -# Switch migration to postcopy mode
> > +# Followup to a migration command to switch the migration to postcopy mode.
> 
> Maybe "Followup to the migrate command to switch the migration..."
> 
> But the wording you have also covers the case if we add something other
> than just 'migrate' to start a migration, so I'm fine either way.
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks,

Dave

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK