From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48054)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Zwvdo-0006cc-T4
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 12:26:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Zwvdl-0007GE-OF
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 12:26:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34016)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Zwvdl-0007G1-J2
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 12:26:29 -0500
Date: Thu, 12 Nov 2015 17:26:24 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20151112172624.GA11416@work-vm>
References: <1447328084-11563-1-git-send-email-dgilbert@redhat.com>
	<5644ADA2.5090505@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5644ADA2.5090505@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] migrate-start-postcopy: Improve text
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: amit.shah@redhat.com, borntraeger@de.ibm.com, bharata@linux.vnet.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com

* Eric Blake (eblake@redhat.com) wrote:
> On 11/12/2015 04:34 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > Improve the text in both the qapi-schema and hmp help to point out
> > you need to set the postcopy-ram capability prior to issuing
> > migrate-start-postcopy.
> > 
> > Also fix the text of the migrate_start_postcopy error that
> > deals with capabilities.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> > v2
> >   Updated text to Erik's suggestion
> 
> It's Eric, but you're not the first (nor the last) to make that typo.

Oops sorry about that.


> > +++ b/qapi-schema.json
> > @@ -706,7 +706,9 @@
> >  ##
> >  # @migrate-start-postcopy
> >  #
> > -# Switch migration to postcopy mode
> > +# Followup to a migration command to switch the migration to postcopy mode.
> 
> Maybe "Followup to the migrate command to switch the migration..."
> 
> But the wording you have also covers the case if we add something other
> than just 'migrate' to start a migration, so I'm fine either way.
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks,

Dave

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK