From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost
Date: Thu, 12 Nov 2015 19:00:54 +0100 [thread overview]
Message-ID: <20151112190054.62bcfa70.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20151109175816.4076.17152.stgit@bahia.huguette.org>
On Mon, 09 Nov 2015 18:58:16 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian()
> indeed returns the runtime state of the virtio device. However, it returns
> false unconditionally in the general case. This sounds a bit strange
> given the name of the function.
>
> This helper is only useful for vhost actually, where indeed non bi-endian
> targets don't have to deal with cross-endian issues.
>
> This patch moves the helper to vhost.c and gives it a more appropriate name.
>
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
> hw/virtio/vhost.c | 17 +++++++++++++++--
> include/hw/virtio/virtio-access.h | 13 -------------
> 2 files changed, 15 insertions(+), 15 deletions(-)
That's on top of your vnet header cleanup, right? With that in mind:
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2015-11-12 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 17:58 [Qemu-devel] [PATCH 0/3] virtio: cross-endian helpers fixes Greg Kurz
2015-11-09 17:58 ` [Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost Greg Kurz
2015-11-12 18:00 ` Cornelia Huck [this message]
2015-11-13 8:28 ` Greg Kurz
2015-11-09 17:58 ` [Qemu-devel] [PATCH 2/3] vhost: move virtio 1.0 check to cross-endian helper Greg Kurz
2015-11-12 18:03 ` Cornelia Huck
2015-11-09 17:58 ` [Qemu-devel] [PATCH 3/3] virtio: optimize virtio_access_is_big_endian() for little-endian targets Greg Kurz
2015-11-12 18:08 ` Cornelia Huck
2015-11-13 9:28 ` Greg Kurz
2015-11-13 14:42 ` Cornelia Huck
2015-11-13 15:25 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112190054.62bcfa70.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).