From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwwBH-00070u-Ky for qemu-devel@nongnu.org; Thu, 12 Nov 2015 13:01:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwwBC-0002kA-3B for qemu-devel@nongnu.org; Thu, 12 Nov 2015 13:01:07 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:42210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwwBB-0002jO-JC for qemu-devel@nongnu.org; Thu, 12 Nov 2015 13:01:02 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Nov 2015 18:01:00 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B522917D805D for ; Thu, 12 Nov 2015 18:01:16 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tACI0vSW7602666 for ; Thu, 12 Nov 2015 18:00:57 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tACI0u3B004026 for ; Thu, 12 Nov 2015 11:00:56 -0700 Date: Thu, 12 Nov 2015 19:00:54 +0100 From: Cornelia Huck Message-ID: <20151112190054.62bcfa70.cornelia.huck@de.ibm.com> In-Reply-To: <20151109175816.4076.17152.stgit@bahia.huguette.org> References: <20151109175333.4076.49180.stgit@bahia.huguette.org> <20151109175816.4076.17152.stgit@bahia.huguette.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On Mon, 09 Nov 2015 18:58:16 +0100 Greg Kurz wrote: > If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() > indeed returns the runtime state of the virtio device. However, it returns > false unconditionally in the general case. This sounds a bit strange > given the name of the function. > > This helper is only useful for vhost actually, where indeed non bi-endian > targets don't have to deal with cross-endian issues. > > This patch moves the helper to vhost.c and gives it a more appropriate name. > > Signed-off-by: Greg Kurz > --- > hw/virtio/vhost.c | 17 +++++++++++++++-- > include/hw/virtio/virtio-access.h | 13 ------------- > 2 files changed, 15 insertions(+), 15 deletions(-) That's on top of your vnet header cleanup, right? With that in mind: Reviewed-by: Cornelia Huck