From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx9iX-0005Tg-Vp for qemu-devel@nongnu.org; Fri, 13 Nov 2015 03:28:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zx9iU-0006yQ-P0 for qemu-devel@nongnu.org; Fri, 13 Nov 2015 03:28:21 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:54893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zx9iU-0006yK-Dh for qemu-devel@nongnu.org; Fri, 13 Nov 2015 03:28:18 -0500 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Nov 2015 08:28:17 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3A74F17D8056 for ; Fri, 13 Nov 2015 08:28:35 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tAD8SFFh10355158 for ; Fri, 13 Nov 2015 08:28:15 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tAD8SFau006028 for ; Fri, 13 Nov 2015 01:28:15 -0700 Date: Fri, 13 Nov 2015 09:28:12 +0100 From: Greg Kurz Message-ID: <20151113092812.62a1834d@bahia.local> In-Reply-To: <20151112190054.62bcfa70.cornelia.huck@de.ibm.com> References: <20151109175333.4076.49180.stgit@bahia.huguette.org> <20151109175816.4076.17152.stgit@bahia.huguette.org> <20151112190054.62bcfa70.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On Thu, 12 Nov 2015 19:00:54 +0100 Cornelia Huck wrote: > On Mon, 09 Nov 2015 18:58:16 +0100 > Greg Kurz wrote: > > > If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() > > indeed returns the runtime state of the virtio device. However, it returns > > false unconditionally in the general case. This sounds a bit strange > > given the name of the function. > > > > This helper is only useful for vhost actually, where indeed non bi-endian > > targets don't have to deal with cross-endian issues. > > > > This patch moves the helper to vhost.c and gives it a more appropriate name. > > > > Signed-off-by: Greg Kurz > > --- > > hw/virtio/vhost.c | 17 +++++++++++++++-- > > include/hw/virtio/virtio-access.h | 13 ------------- > > 2 files changed, 15 insertions(+), 15 deletions(-) > > That's on top of your vnet header cleanup, right? With that in mind: > Yes. > Reviewed-by: Cornelia Huck Thanks for your time ! -- Greg