From: Stefan Hajnoczi <stefanha@gmail.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: make 'stats-intervals' a list of integers
Date: Fri, 13 Nov 2015 18:15:52 +0800 [thread overview]
Message-ID: <20151113101552.GF6650@stefanha-x1.localdomain> (raw)
In-Reply-To: <1447247832-14198-1-git-send-email-berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Wed, Nov 11, 2015 at 03:17:12PM +0200, Alberto Garcia wrote:
> This is the natural JSON representation and prevents us from having to
> decode the list manually.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> blockdev.c | 64 ++++++++++++++++++++++++++++++++++----------------
> qapi/block-core.json | 7 +++---
> tests/qemu-iotests/136 | 2 +-
> 3 files changed, 48 insertions(+), 25 deletions(-)
gcc 5.1.1 warning:
blockdev.c: In function ‘blockdev_init’:
blockdev.c:636:17: error: ‘length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
block_acct_add_interval(blk_get_stats(blk), length);
^
blockdev.c:597:22: note: ‘length’ was declared here
unsigned length;
^
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-13 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 13:17 [Qemu-devel] [PATCH] block: make 'stats-intervals' a list of integers Alberto Garcia
2015-11-11 15:32 ` [Qemu-devel] [PATCH for-2.5] " Eric Blake
2015-11-11 15:38 ` Alberto Garcia
2015-11-13 10:15 ` Stefan Hajnoczi [this message]
2015-11-13 10:50 ` [Qemu-devel] [Qemu-block] [PATCH] " Alberto Garcia
2015-11-16 3:47 ` Stefan Hajnoczi
2015-11-16 3:46 ` Stefan Hajnoczi
2015-11-16 8:28 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113101552.GF6650@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).