From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxbvT-0001Jn-MG for qemu-devel@nongnu.org; Sat, 14 Nov 2015 09:35:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxbvO-00018Y-Iw for qemu-devel@nongnu.org; Sat, 14 Nov 2015 09:35:35 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:50562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxbvO-000180-6n for qemu-devel@nongnu.org; Sat, 14 Nov 2015 09:35:30 -0500 Received: from localhost by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 14 Nov 2015 07:35:28 -0700 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 26F3E1FF002D for ; Sat, 14 Nov 2015 07:23:35 -0700 (MST) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tAEEXt733866892 for ; Sat, 14 Nov 2015 07:33:55 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tAEEZNPq025357 for ; Sat, 14 Nov 2015 07:35:23 -0700 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1447454404-10754-3-git-send-email-mdroth@linux.vnet.ibm.com> References: <1447454404-10754-1-git-send-email-mdroth@linux.vnet.ibm.com> <1447454404-10754-3-git-send-email-mdroth@linux.vnet.ibm.com> Message-ID: <20151114143516.7353.9765@loki> Date: Sat, 14 Nov 2015 08:35:16 -0600 Subject: Re: [Qemu-devel] [PULL for-2.5 2/2] qga: allow to lookup in PATH from the passed envp for guest-exec List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Yuri Pudgorodskiy , "Denis V. Lunev" Quoting Michael Roth (2015-11-13 16:40:04) > From: Yuri Pudgorodskiy > = > This was original behaviour before GLIB gspawn() rework and we rely on > this behaviour. > = > Signed-off-by: Yuri Pudgorodskiy > Signed-off-by: Denis V. Lunev > CC: Michael Roth > Signed-off-by: Michael Roth > --- > qga/commands.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > = > diff --git a/qga/commands.c b/qga/commands.c > index 7644ca0..559f18f 100644 > --- a/qga/commands.c > +++ b/qga/commands.c > @@ -400,7 +400,8 @@ GuestExec *qmp_guest_exec(const char *path, > argv =3D guest_exec_get_args(&arglist, true); > envp =3D has_env ? guest_exec_get_args(env, false) : NULL; > = > - flags =3D G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD; > + flags =3D G_SPAWN_SEARCH_PATH | G_SPAWN_SEARCH_PATH_FROM_ENVP | Sorry, just noticed this was only added around 2.33. I'll send updated PULL that adds a version check. > + G_SPAWN_DO_NOT_REAP_CHILD; > if (!has_output) { > flags |=3D G_SPAWN_STDOUT_TO_DEV_NULL | G_SPAWN_STDERR_TO_DEV_NU= LL; > } > -- = > 1.9.1 >=20