From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyCYi-0007lu-2Y for qemu-devel@nongnu.org; Mon, 16 Nov 2015 00:42:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyCYg-0007sR-MJ for qemu-devel@nongnu.org; Mon, 16 Nov 2015 00:42:31 -0500 Date: Mon, 16 Nov 2015 16:34:05 +1100 From: David Gibson Message-ID: <20151116053405.GH2747@voom.fritz.box> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-14-git-send-email-benh@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82evfD9Ogz2JrdWZ" Content-Disposition: inline In-Reply-To: <1447201710-10229-14-git-send-email-benh@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 13/77] ppc: tlbie, tlbia and tlbisync are HV only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --82evfD9Ogz2JrdWZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 11, 2015 at 11:27:26AM +1100, Benjamin Herrenschmidt wrote: > Not that anything remotely recent supports tlbia but ... >=20 > Signed-off-by: Benjamin Herrenschmidt > --- > target-ppc/translate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 10eb9e3..014fe5e 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -4836,7 +4836,7 @@ static void gen_tlbia(DisasContext *ctx) > #if defined(CONFIG_USER_ONLY) > gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > #else > - if (unlikely(ctx->pr)) { > + if (unlikely(ctx->pr || !ctx->hv)) { If I'm reading your previous patch correctly, ctx->hv won't be set with in problem state, so I think the ctx->pr check is redundant. > gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > return; > } > @@ -4850,7 +4850,7 @@ static void gen_tlbiel(DisasContext *ctx) > #if defined(CONFIG_USER_ONLY) > gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > #else > - if (unlikely(ctx->pr)) { > + if (unlikely(ctx->pr || !ctx->hv)) { > gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > return; > } > @@ -4864,7 +4864,7 @@ static void gen_tlbie(DisasContext *ctx) > #if defined(CONFIG_USER_ONLY) > gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > #else > - if (unlikely(ctx->pr)) { > + if (unlikely(ctx->pr || !ctx->hv)) { > gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > return; > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --82evfD9Ogz2JrdWZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWSWrNAAoJEGw4ysog2bOSVIMQAI/HD+Yfj/i5ea3Qdton88jD JIh6GLDWs2MhkLKs7O827+m+FHivLWl+52FIZqrX4h6Uh4qNlu88NJPu9Jehde3s QEWyKaS7IVO1EOH0/Qw5zgRhHK7bAfeHIETY5+9akqq8ZcDbsnhqWRKiHSGltodK tgQ4EGMSD1BFxTdN65nqvkH5ompZiKMroVG2C/tuszYjefY/aKVOD3YCKswOUOXr Z6dDsZSJ8Zt/AE/a20mrPq0uG3T02y9GN+v1MavmpwWItNPuFgrljdme5JIZhH2a 6XIB3skeYYGrGxse6I8JpKW3U3EC8wbNiejPD3Ho6AVfRj484l2pm3A3h2/9SP1N BZRr+j+QsULhompGucbetDoxYRUDdZ7czsjJ4tvWY8T9Xbi7gIh1Y4RR912D4OYZ Do0UrhnkQ3J1F5Lki1jJCankFiR5loGysmU0KMT5Omu+ATRTNgSicdmq5VuglvdD HEtTDCmeoy15dkyHwKujmzUhukSZYQTxsNIShKiRD+GAFsawdtzMUcZgEEetHvAd cGyRlAY8Bilp27P+A/70Dko1GEiL78GBLNxniO7IZ4A3FEXIshJVkX5AKYCWulX1 ub5bOlh6UJvlztSTcPFA6uHjY0PbdAszOIcJYs7ytdBulLRhPBXRyR1VY5H/jurZ 8iDKkpdfE8lpYeWWhtkl =tLcu -----END PGP SIGNATURE----- --82evfD9Ogz2JrdWZ--