From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36929)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZyCyY-0001EU-7z
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 01:09:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZyCyX-0006kL-Ai
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 01:09:14 -0500
Date: Mon, 16 Nov 2015 14:09:03 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151116060903.GB20672@ad.usersys.redhat.com>
References: <1447419624-21918-1-git-send-email-berto@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447419624-21918-1-git-send-email-berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH for-2.5] block: Call
 external_snapshot_clean after blockdev-snapshot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>

On Fri, 11/13 15:00, Alberto Garcia wrote:
> Otherwise the AioContext will never be released.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  blockdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/blockdev.c b/blockdev.c
> index fc85128..4dcc510 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2070,6 +2070,7 @@ static const BlkActionOps actions[] = {
>          .prepare  = external_snapshot_prepare,
>          .commit   = external_snapshot_commit,
>          .abort = external_snapshot_abort,
> +        .clean = external_snapshot_clean,
>      },
>      [TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC] = {
>          .instance_size = sizeof(ExternalSnapshotState),
> -- 
> 2.6.2
> 

Reviewed-by: Fam Zheng <famz@redhat.com>