From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyJAq-0005bk-Er for qemu-devel@nongnu.org; Mon, 16 Nov 2015 07:46:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyJAm-0004iz-6p for qemu-devel@nongnu.org; Mon, 16 Nov 2015 07:46:20 -0500 Date: Mon, 16 Nov 2015 23:42:43 +1100 From: David Gibson Message-ID: <20151116124243.GO2747@voom.fritz.box> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-3-git-send-email-benh@kernel.crashing.org> <20151116044908.GA2747@voom.fritz.box> <1447668624.3081.85.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s9kDAZ2EyO0AcRYa" Content-Disposition: inline In-Reply-To: <1447668624.3081.85.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/77] ppc: Use split I/D mmu modes to avoid flushes on interrupts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --s9kDAZ2EyO0AcRYa Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 16, 2015 at 09:10:24PM +1100, Benjamin Herrenschmidt wrote: > Thanks for reviewing ! > On Mon, 2015-11-16 at 15:49 +1100, David Gibson wrote: [snip] > > > diff --git a/target-ppc/machine.c b/target-ppc/machine.c > > > index f4ac761..b969492 100644 > > > --- a/target-ppc/machine.c > > > +++ b/target-ppc/machine.c > > > @@ -90,9 +90,11 @@ static int cpu_load_old(QEMUFile *f, void > > > *opaque, int version_id) > > > =A0=A0=A0=A0=A0qemu_get_betls(f, &env->nip); > > > =A0=A0=A0=A0=A0qemu_get_betls(f, &env->hflags); > > > =A0=A0=A0=A0=A0qemu_get_betls(f, &env->hflags_nmsr); > > > -=A0=A0=A0=A0qemu_get_sbe32s(f, &env->mmu_idx); > >=20 > > Have I missed something, or do you still need a read here to read the > > mmux_idx, even though you'll ignore it, otherwise you'll get out of > > sync and break migration from an old stream. >=20 > I am not completely cognizant of the migration stuff, that's very > possible yes. Do I need to read into a dummy local ? Or is there > a way to just say "drop 4 bytes from stream" ? There's actually an example of this just below :) > Note that I have generally completely overlooked the migration impact > of my patches, this is something that I need to do but I wouldn't mind > your help identifying the parts. Ok, I'll do what I can. > > > =A0=A0=A0=A0=A0qemu_get_sbe32(f); /* Discard unused power_mode */ ^^^ example of skipping a redundant value in the migration stream --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --s9kDAZ2EyO0AcRYa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWSc9DAAoJEGw4ysog2bOSbZQP/iHDtmy2xwSMa3dIA6tM3iRJ ew9miDol0iQ2JUNf0zhOAalAbiJNGOH4xJB94/OFBtAMQnT8sMIhRwRCCIgSpDCe LpY68MVMGvAkKBIjcwq3hcRNHUNVIok4mmqXkv8vSH8JIzd/5iFEkCvt2z01AAV0 dlF2bzmA7I3G6o5qrHSbq3M7974OMjfy1uAaacW1bbLb2s3GMLCLGdIq9wBJ+ECi fDer+gLT4rr0Bw1byCkSgYgFGzMquoyYLX8n7pXTB0sKLiV0AXe0ZYILGLN0/SKg tvAgkMSuOK6adK9SaRXrNC1kzgd4Ix9KxHOlFcrmcYvqBcBgCRICUBDejZCbN+ff PRn//alOMGGgyDvM8bm/3Zy5D857zFgOgrDYJTymSC7NMvlSRKtXBD6+T4Eagkxs EGOTRQS67/VacIY7aH14uymiP9wU09l7qhHelI5ecRR4iPRrfqe71W3Zd96Iejdp s0J+zbUV4txGocY804jd1DnsRHflO5a4yhhEanSzp43nQkIkdxxN+H4EaZgpKMJ2 nD6i0kMvPQRNLskrvh1q+ga9vspHNfREgvnyLrcYaS4D5EGXOUPOsdoEjd8762lr 58Ic+okprxfkKuT5K7mvDy3A6l90mvIHNEoaOx4ZwInMT1jsPA8QHMJBkv0v2sgx jTNY7FUK1f/HpVeTiw1o =mrJF -----END PGP SIGNATURE----- --s9kDAZ2EyO0AcRYa--