From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyKdg-0004u4-8w for qemu-devel@nongnu.org; Mon, 16 Nov 2015 09:20:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyKdb-0007o4-DD for qemu-devel@nongnu.org; Mon, 16 Nov 2015 09:20:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyKdb-0007mX-6b for qemu-devel@nongnu.org; Mon, 16 Nov 2015 09:20:07 -0500 Date: Mon, 16 Nov 2015 14:20:00 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20151116141959.GA8530@work-vm> References: <1447165546-27784-1-git-send-email-quintela@redhat.com> <1447165546-27784-26-git-send-email-quintela@redhat.com> <5647877D.6050201@weilnetz.de> <20151116100734.GB2417@work-vm> <5649D6BF.20204@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5649D6BF.20204@weilnetz.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 25/57] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: amit.shah@redhat.com, Paolo Bonzini , qemu-devel@nongnu.org, Juan Quintela * Stefan Weil (sw@weilnetz.de) wrote: > Am 16.11.2015 um 11:07 schrieb Dr. David Alan Gilbert: > > * Stefan Weil (sw@weilnetz.de) wrote: > >> Am 10.11.2015 um 15:25 schrieb Juan Quintela: > >>> From: "Dr. David Alan Gilbert" > >>> > >>> The state of the postcopy process is managed via a series of messag= es; > >>> * Add wrappers and handlers for sending/receiving these messages > >>> * Add state variable that track the current state of postcopy > >>> > >>> Signed-off-by: Dr. David Alan Gilbert > >>> Reviewed-by: Amit Shah > >>> Reviewed-by: Juan Quintela > >>> Signed-off-by: Juan Quintela > >>> --- > >>> include/migration/migration.h | 27 +++++ > >>> include/sysemu/sysemu.h | 19 ++++ > >>> migration/migration.c | 20 ++++ > >>> migration/savevm.c | 254 ++++++++++++++++++++++++++++++= ++++++++++++ > >>> trace-events | 10 ++ > >>> 5 files changed, 330 insertions(+) > >>> > >> [...] > >>> diff --git a/migration/savevm.c b/migration/savevm.c > >> [...] > >>> + if (remote_hps !=3D getpagesize()) { > >>> + /* > >>> + * Some combinations of mismatch are probably possible but= it gets > >>> + * a bit more complicated. In particular we need to place= whole > >>> + * host pages on the dest at once, and we need to ensure t= hat we > >>> + * handle dirtying to make sure we never end up sending pa= rt of > >>> + * a hostpage on it's own. > >>> + */ > >>> + error_report("Postcopy needs matching host page sizes (s=3D= %d d=3D%d)", > >>> + (int)remote_hps, getpagesize()); > >> > >> This statement introduces a new warning when compiling for > >> Windows where getpagesize() returns a size_t. I'll send a patch > >> to change that definition to return an int value. > >=20 > > Interesting; which compiler are you using; I don't think any of us te= sting with > > ming hit that. >=20 > I use Debian GNU Linux jessie with package gcc-mingw-w64-x86-64. >=20 > CC i386-softmmu/migration/savevm.o > migration/savevm.c: In function =E2=80=98loadvm_postcopy_handle_advise=E2= =80=99: > migration/savevm.c:1284:22: warning: format =E2=80=98%d=E2=80=99 expect= s argument of > type =E2=80=98int=E2=80=99, but argument 3 has type =E2=80=98size_t=E2=80= =99 [-Wformat=3D] > (int)remote_hps, getpagesize()); > ^ > $ x86_64-w64-mingw32-gcc --version > x86_64-w64-mingw32-gcc (GCC) 4.9.1 > Copyright (C) 2014 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is= NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURP= OSE. Ah OK, I see that but only when I build with a 64bit mingw. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK