* [Qemu-devel] [PATCH] vhost-user-test: don't rely on RESET_OWNER
@ 2015-11-16 11:57 Michael S. Tsirkin
2015-11-16 12:35 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2015-11-16 11:57 UTC (permalink / raw)
To: qemu-devel
Cc: Marcel Apfelbaum, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?=,
Yuanhan Liu, Paolo Bonzini
vhost-user-test is broken now: it assumes
QEMU sends RESET_OWNER, and we stopped doing that.
Wait for ENABLE_RING with 0 instead.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/vhost-user-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index 431aa9f..3593803 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -321,7 +321,9 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
break;
case VHOST_USER_SET_VRING_ENABLE:
- s->fds_num = 0;
+ if (!msg.payload.state.num) {
+ s->fds_num = 0;
+ }
break;
default:
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] vhost-user-test: don't rely on RESET_OWNER
2015-11-16 11:57 [Qemu-devel] [PATCH] vhost-user-test: don't rely on RESET_OWNER Michael S. Tsirkin
@ 2015-11-16 12:35 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2015-11-16 12:35 UTC (permalink / raw)
To: qemu-devel
Cc: Marcel Apfelbaum, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?=,
Yuanhan Liu, Paolo Bonzini
On Mon, Nov 16, 2015 at 01:57:45PM +0200, Michael S. Tsirkin wrote:
> vhost-user-test is broken now: it assumes
> QEMU sends RESET_OWNER, and we stopped doing that.
> Wait for ENABLE_RING with 0 instead.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Sorry wrong patch. Pls ignore.
> ---
> tests/vhost-user-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 431aa9f..3593803 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -321,7 +321,9 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
> break;
>
> case VHOST_USER_SET_VRING_ENABLE:
> - s->fds_num = 0;
> + if (!msg.payload.state.num) {
> + s->fds_num = 0;
> + }
> break;
>
> default:
> --
> MST
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-16 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 11:57 [Qemu-devel] [PATCH] vhost-user-test: don't rely on RESET_OWNER Michael S. Tsirkin
2015-11-16 12:35 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).