From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZyJ0s-0004vd-GZ
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 07:36:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZyJ0p-0002Bj-9O
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 07:36:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZyJ0p-0002Bf-3m
	for qemu-devel@nongnu.org; Mon, 16 Nov 2015 07:35:59 -0500
Date: Mon, 16 Nov 2015 14:35:55 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151116143543-mutt-send-email-mst@redhat.com>
References: <1447675059-7277-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447675059-7277-1-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vhost-user-test: don't rely on RESET_OWNER
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel@redhat.com>, =?us-ascii?B?PT9VVEYtOD9xP01hcmMtQW5kcj1DMz1BOT0yMEx1cmVhdT89?= <marcandre.lureau@redhat.com>, Yuanhan Liu <yuanhan.liu@linux.intel.com>, Paolo Bonzini <pbonzini@redhat.com>

On Mon, Nov 16, 2015 at 01:57:45PM +0200, Michael S. Tsirkin wrote:
> vhost-user-test is broken now: it assumes
> QEMU sends RESET_OWNER, and we stopped doing that.
> Wait for ENABLE_RING with 0 instead.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Sorry wrong patch. Pls ignore.

> ---
>  tests/vhost-user-test.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 431aa9f..3593803 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -321,7 +321,9 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
>          break;
>  
>      case VHOST_USER_SET_VRING_ENABLE:
> -        s->fds_num = 0;
> +        if (!msg.payload.state.num) {
> +            s->fds_num = 0;
> +        }
>          break;
>  
>      default:
> -- 
> MST