From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyN9Q-0007WM-H7 for qemu-devel@nongnu.org; Mon, 16 Nov 2015 12:01:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyN9N-00022Y-B5 for qemu-devel@nongnu.org; Mon, 16 Nov 2015 12:01:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyN9N-00022G-6q for qemu-devel@nongnu.org; Mon, 16 Nov 2015 12:01:05 -0500 Date: Mon, 16 Nov 2015 17:01:01 +0000 From: "Daniel P. Berrange" Message-ID: <20151116170101.GG20157@redhat.com> References: <1447693029-25683-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1447693029-25683-1-git-send-email-afaerber@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qom: Clean up assertions to display values on failure Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: qemu-devel@nongnu.org On Mon, Nov 16, 2015 at 05:57:09PM +0100, Andreas F=C3=A4rber wrote: > Instead of using g_assert() for integer comparisons, use > g_assert_cmpint() so that we can see the respective values. >=20 > While at it, fix one stray indentation. >=20 > Cc: Daniel P. Berrange > Signed-off-by: Andreas F=C3=A4rber Reviewed-by: Daniel P. Berrange Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|