From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyP1V-0007Mo-Cx for qemu-devel@nongnu.org; Mon, 16 Nov 2015 14:01:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyP1R-0000MF-9p for qemu-devel@nongnu.org; Mon, 16 Nov 2015 14:01:05 -0500 Received: from e17.ny.us.ibm.com ([129.33.205.207]:51842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyP1R-0000Ls-4h for qemu-devel@nongnu.org; Mon, 16 Nov 2015 14:01:01 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Nov 2015 14:00:58 -0500 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 5559C38C803B for ; Mon, 16 Nov 2015 14:00:56 -0500 (EST) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tAGJ0tf566060412 for ; Mon, 16 Nov 2015 19:00:56 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tAGJ0t3K011377 for ; Mon, 16 Nov 2015 14:00:55 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: References: <1447454404-10754-1-git-send-email-mdroth@linux.vnet.ibm.com> Message-ID: <20151116190038.6257.37815@loki> Date: Mon, 16 Nov 2015 13:00:38 -0600 Subject: Re: [Qemu-devel] [PULL for-2.5 0/2] qemu-ga patch queue for 2.5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers Quoting Peter Maydell (2015-11-16 06:09:17) > On 13 November 2015 at 22:40, Michael Roth wr= ote: > > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68= 012a: > > > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +0000) > > > > are available in the git repository at: > > > > git://github.com/mdroth/qemu.git tags/qga-pull-2015-11-13-tag > > > > for you to fetch changes up to 8144e432d8c8e801a906c126afc1333985fad0ce: > > > > qga: allow to lookup in PATH from the passed envp for guest-exec (201= 5-11-13 16:31:32 -0600) > > > > ---------------------------------------------------------------- > > qemu-ga patch queue for 2.5 > > > > * fixes for guest-exec gspawn() usage: > > - inherit default lookup path by default instead of > > explicitly defining it as being empty. > > - don't inherit default PATH when PATH/ENV are explicit > > > > ---------------------------------------------------------------- > = > Hi. I'm afraid this doesn't build against our minimum supported > glib version: > = > /Users/pm215/src/qemu-for-merges/qga/commands.c:403:35: error: use of > undeclared identifier 'G_SPAWN_SEARCH_PATH_FROM_ENVP' > = > Looks like that feature was only added in glib 2.34 or thereabouts. Sorry, I noticed this after submitting. I commented on it in response to patch 2, but probably should've posted a top-level reply. I've added a version check (it appears to be 2.33.2) in v2, but I'm trying to get 1 more qga fix ("makefile: fix w32 install target for qemu-ga") in before resubmitting. > = > thanks > -- PMM >=20