From: "Daniel P. Berrange" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds
Date: Tue, 17 Nov 2015 17:25:26 +0000 [thread overview]
Message-ID: <20151117172526.GK14972@redhat.com> (raw)
In-Reply-To: <1447419672.1400.113.camel@redhat.com>
On Fri, Nov 13, 2015 at 02:01:12PM +0100, Gerd Hoffmann wrote:
> On Fr, 2015-11-13 at 11:31 +0000, Daniel P. Berrange wrote:
> > Developers on 64-bit machines will often try to perform a
> > 32-bit build of QEMU by running
> >
> > ./configure --extra-cflags="-m32"
> >
> > Unfortunately if PKG_CONFIG_LIBDIR is not set to point to
> > the location of the 32-bit pkg-config files, then configure
> > will silently pick up the 64-bit pkg-config files and still
> > succeed.
>
> While being at it: I think it would be a good idea to record
> PKG_CONFIG_LIBDIR in config.status, otherwise it'll be lost the next
> time configure is touched and make figures it needs to re-run configure.
In the spirit of doing one logical change per patch, I'm sending a
separate patch to cover this suggestion.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2015-11-17 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 11:31 [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds Daniel P. Berrange
2015-11-13 12:54 ` Dr. David Alan Gilbert
2015-11-13 13:01 ` Gerd Hoffmann
2015-11-17 17:25 ` Daniel P. Berrange [this message]
2015-11-13 13:01 ` Peter Maydell
2015-11-13 14:16 ` Daniel P. Berrange
2016-01-25 14:42 ` Peter Maydell
2016-01-25 14:47 ` Daniel P. Berrange
2016-01-25 14:58 ` Peter Maydell
2016-01-25 15:00 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117172526.GK14972@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).