From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyk0e-0001pP-Ik for qemu-devel@nongnu.org; Tue, 17 Nov 2015 12:25:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zyk0Y-0001jy-J2 for qemu-devel@nongnu.org; Tue, 17 Nov 2015 12:25:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zyk0Y-0001js-Cm for qemu-devel@nongnu.org; Tue, 17 Nov 2015 12:25:30 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 08A03AACD3 for ; Tue, 17 Nov 2015 17:25:30 +0000 (UTC) Date: Tue, 17 Nov 2015 17:25:26 +0000 From: "Daniel P. Berrange" Message-ID: <20151117172526.GK14972@redhat.com> References: <1447414307-5295-1-git-send-email-berrange@redhat.com> <1447419672.1400.113.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1447419672.1400.113.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib library that pkg-config finds Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" On Fri, Nov 13, 2015 at 02:01:12PM +0100, Gerd Hoffmann wrote: > On Fr, 2015-11-13 at 11:31 +0000, Daniel P. Berrange wrote: > > Developers on 64-bit machines will often try to perform a > > 32-bit build of QEMU by running > > > > ./configure --extra-cflags="-m32" > > > > Unfortunately if PKG_CONFIG_LIBDIR is not set to point to > > the location of the 32-bit pkg-config files, then configure > > will silently pick up the 64-bit pkg-config files and still > > succeed. > > While being at it: I think it would be a good idea to record > PKG_CONFIG_LIBDIR in config.status, otherwise it'll be lost the next > time configure is touched and make figures it needs to re-run configure. In the spirit of doing one logical change per patch, I'm sending a separate patch to cover this suggestion. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|