From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz0K3-0001bo-FB for qemu-devel@nongnu.org; Wed, 18 Nov 2015 05:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz0Jz-0007r1-A1 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 05:50:43 -0500 Date: Wed, 18 Nov 2015 21:49:28 +1100 From: David Gibson Message-ID: <20151118104927.GA3298@voom.fritz.box> References: <1447051637-45246-1-git-send-email-aik@ozlabs.ru> <20151109084731.GH18558@voom.redhat.com> <564C2CA3.8000307@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <564C2CA3.8000307@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu] spapr: Add /system-id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey Kardashevskiy wrote: > On 11/09/2015 07:47 PM, David Gibson wrote: > >On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote: > >>Section B.6.2.1 Root Node Properties of PAPR specification defines > >>a set of properties which shall be present in the device tree root, > >>one of these properties is "system-id" which "should be unique across > >>all systems and all manufacturers". Since UUID is meant to be unique, > >>it makes sense to use it as "system-id". > >> > >>This adds "system-id" property to the device tree root when not empty. > >> > >>Signed-off-by: Alexey Kardashevskiy > >>--- > >> > >>This might be expected by AIX so here is the patch. > >>I am really not sure if it makes sense to initialize property when > >>UUID is all zeroes as the requirement is "unique" and zero-uuid is > >>not. > > > >Yeah, I think it would be better to omit system-id entirely when a > >UUID hasn't been supplied. >=20 >=20 > so this did not go anywhere yet, did it? No. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWTFe3AAoJEGw4ysog2bOSAJIQANOJCZgG2Np6IqggHqnWNGSE 3TTz8KTE5TOKwSFUSd0EgB+7BhjmLvgOwhh+uzmdACvHXVOiJpLUj8meY9+xqUuY 2zRle0wN3HB/DtKYa1A8Vn6guLhcmzw5kN/kT3TPiQ3jJZqIeL/fu68rsQG9wFzI V4nrfwOYEFiL0x1zn6IEUkOCTN+QodXZSYl2RasXiEldPYc6Ji2GH2eHYWSnia0q EkijxvSBzNxJLs3JgyaeyxAHZ59U0tpY5LjUa4+uNN+dhkLnupH3tJhvy+XN6+Ov u/biEIZh+9AHpBKi9MbpE5/zoQOSigG8vGl+jDUhgXpFl5d8U2rV4vp6O6aBZ2c0 oKFPt7Mzy2ygcpxSG7FiEkcf88k1pE68OT6hBla9ZMNM8yWV+j22l//mY6hwn/qd VgJvkSh0F6xmR626g/d3jTGaKVG+BPIc631Hjhs8kCXhfFH/zb3Qarp7DTWep4i8 LPSToFYrbS9iVvtSgpYV5p2JSBlDMPuFcfzC9aPB8p8CdxDqA66CkD61rrGnFkRb 4ClOIkiyplaDnG0J20CmA8yAbm0LDJffCN8CjzgKCnPSEGM79aAiEmNwJ8D4Y08m Al0n8ekzebR3VtoSo3MyrADNQIF0IKBMpXBIsKRa7Pj/Ke94CGyhrTGPcapHyxJF B/e0icEtR3+MGKvESCwd =UjD5 -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--