From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz5kx-00032O-OI for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:38:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz5kt-0006TE-Oq for qemu-devel@nongnu.org; Wed, 18 Nov 2015 11:38:51 -0500 Date: Wed, 18 Nov 2015 18:38:41 +0200 From: "Michael S. Tsirkin" Message-ID: <20151118183808-mutt-send-email-mst@redhat.com> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-45-git-send-email-benh@kernel.crashing.org> <564C6FB3.1000703@redhat.com> <564C720B.10106@redhat.com> <20151118161859-mutt-send-email-mst@redhat.com> <564C8A55.1090501@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564C8A55.1090501@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.5 44/77] pci-bridge: Set a supported devfn_min for bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Wed, Nov 18, 2015 at 03:25:25PM +0100, Paolo Bonzini wrote: > > > On 18/11/2015 15:21, Michael S. Tsirkin wrote: > > This depends on the devfn_min thing, right? > > I'm yet to review it, generally I'd prefer to > > avoid changing device allocation rules since > > that makes it so easy to break compatibility. > > > > Assuming addresses are all explicitly stated, > > is there even a problem? > > It makes it a bit easier to use pci-bridge; it is a bug, albeit one that > only affects direct usage through the command line of PCI bridges. > > Paolo Yes but not a regression ... I'll look at how invasive the change it depends on is.