From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com,
qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com,
pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM
Date: Wed, 18 Nov 2015 22:44:21 +0200 [thread overview]
Message-ID: <20151118224253-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20151118191817.GK20436@thinpad.lan.raisama.net>
On Wed, Nov 18, 2015 at 05:18:17PM -0200, Eduardo Habkost wrote:
> On Wed, Nov 18, 2015 at 09:59:34AM +0800, Xiao Guangrong wrote:
> >
> > Ping...
> >
> > Do you have any comment on this patchset? Could it be applied to somewhere
> > if it is okay for you?
>
> I have no additional comments, as the memory-backend patches I
> was reviewing are not included in this version. I didn't take the
> time to review the TYPE_NVDIMM and ACPI changes.
No, I don't think the way guest memory is allocated here is ok. I'm
sorry, I'm busy with 2.5 now, and this is clearly not 2.5 material.
Once that's out, I'll post some suggestions.
Thanks!
> --
> Eduardo
next prev parent reply other threads:[~2015-11-18 20:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 10:50 [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM Xiao Guangrong
2015-11-16 10:50 ` [Qemu-devel] [PATCH v8 1/5] nvdimm: implement NVDIMM device abstract Xiao Guangrong
2015-11-16 10:51 ` [Qemu-devel] [PATCH v8 2/5] acpi: support specified oem table id for build_header Xiao Guangrong
2015-11-16 10:51 ` [Qemu-devel] [PATCH v8 3/5] nvdimm acpi: build ACPI NFIT table Xiao Guangrong
2015-11-30 10:30 ` Michael S. Tsirkin
2015-11-30 12:29 ` Xiao Guangrong
2015-11-16 10:51 ` [Qemu-devel] [PATCH v8 4/5] nvdimm acpi: build ACPI nvdimm devices Xiao Guangrong
2015-11-30 10:30 ` Michael S. Tsirkin
2015-11-30 12:21 ` Xiao Guangrong
2015-11-30 10:32 ` Michael S. Tsirkin
2015-11-30 12:31 ` Xiao Guangrong
2015-11-16 10:51 ` [Qemu-devel] [PATCH v8 5/5] nvdimm: add maintain info Xiao Guangrong
2015-11-18 1:59 ` [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM Xiao Guangrong
2015-11-18 19:18 ` Eduardo Habkost
2015-11-18 20:44 ` Michael S. Tsirkin [this message]
2015-11-19 2:39 ` Xiao Guangrong
2015-11-19 8:21 ` Michael S. Tsirkin
2015-11-23 8:53 ` Stefan Hajnoczi
2015-11-30 8:51 ` Stefan Hajnoczi
2015-11-30 12:34 ` Xiao Guangrong
2015-11-30 10:38 ` Michael S. Tsirkin
2015-11-30 12:33 ` Xiao Guangrong
2015-12-04 16:38 ` Vladimir Sementsov-Ogievskiy
2015-12-05 4:29 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118224253-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).