From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz9eE-0008Ad-Db for qemu-devel@nongnu.org; Wed, 18 Nov 2015 15:48:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz9eD-0007Uw-Ku for qemu-devel@nongnu.org; Wed, 18 Nov 2015 15:48:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz9eD-0007Ug-Fw for qemu-devel@nongnu.org; Wed, 18 Nov 2015 15:48:09 -0500 Date: Wed, 18 Nov 2015 22:48:06 +0200 From: "Michael S. Tsirkin" Message-ID: <20151118224739-mutt-send-email-mst@redhat.com> References: <20151118162119.9938.45927.stgit@bahia.huguette.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151118162119.9938.45927.stgit@bahia.huguette.org> Subject: Re: [Qemu-devel] [PATCH v3 0/3] virtio-net/vhost-net: share cross-endian enablement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Cornelia Huck , qemu-devel@nongnu.org On Wed, Nov 18, 2015 at 05:23:00PM +0100, Greg Kurz wrote: > Since QEMU 2.4.0, vhost-net uses the cross-endian support of TAP devices to > fix vnet headers. In fact, virtio-net can do the same instead of hackily > patching headers in virtio_net_hdr_swap(). > > This series moves the enablement of cross-endian support from vhost-net to > virtio-net: both vhost and full emulation can now benefit from it. Of course > we keep the current hack to fall back on when the backend doesn't support > cross-endian. Thanks! This is an optimization rather than a bugfix, right? As such I'd rather defer this until after 2.5. > --- > > Greg Kurz (3): > virtio-net: use the backend cross-endian capabilities > Revert "vhost-net: tell tap backend about the vnet endianness" > virtio: drop the virtio_needs_swap() helper > > > hw/net/vhost_net.c | 33 +------------------------------ > hw/net/virtio-net.c | 40 +++++++++++++++++++++++++++++++++++-- > include/hw/virtio/virtio-access.h | 9 -------- > include/hw/virtio/virtio-net.h | 1 + > 4 files changed, 40 insertions(+), 43 deletions(-)