From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzLzX-0002n6-Vc for qemu-devel@nongnu.org; Thu, 19 Nov 2015 04:59:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzLzE-0006oL-EL for qemu-devel@nongnu.org; Thu, 19 Nov 2015 04:58:59 -0500 Date: Thu, 19 Nov 2015 17:09:06 +1100 From: David Gibson Message-ID: <20151119060906.GA10667@voom.redhat.com> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-4-git-send-email-benh@kernel.crashing.org> <20151116050016.GB2747@voom.fritz.box> <1447668968.3081.91.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: <1447668968.3081.91.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/77] ppc: Do some batching of TCG tlb flushes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 16, 2015 at 09:16:08PM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2015-11-16 at 16:00 +1100, David Gibson wrote: > >=A0 > > > =A0//#define DEBUG_MMU > > > =A0//#define DEBUG_BATS > > > @@ -1940,6 +1941,7 @@ void ppc_tlb_invalidate_all(CPUPPCState *env) > > > =A0=A0=A0=A0=A0case POWERPC_MMU_2_03: > > > =A0=A0=A0=A0=A0case POWERPC_MMU_2_06: > > > =A0=A0=A0=A0=A0case POWERPC_MMU_2_07: > > > +=A0=A0=A0=A0=A0=A0=A0=A0env->tlb_need_flush =3D 0; > > > =A0#endif /* defined(TARGET_PPC64) */ > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0tlb_flush(CPU(cpu), 1); > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0break; > >=20 > > Any particular reason you're leaving this one as an immediate rather > > than deferred flush? >=20 > A couple yes. It's mostly unused on server CPUs (we don't do tlbia), > and it's used by ppc_cpu_reset(). In that latter case, I like having > everything really cleaned up ...=A0 >=20 > > Should you be clearing the pending flush flag cpu_reset()? >=20 > That should happen as a result of the above. Ok. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWTWeCAAoJEGw4ysog2bOSU9EP/i3m8zNSKnisMeGwt9RJatNK 58jrVekbPY98uJs76y9NURxrlZ5phD3Iow23ZNApsAfgFlrXVh16k2g/TaEBPnGQ GtlZYgEJjL6sK6x24h6AcxeWPDtamxMZiQojaUIiB0ki4cojiG+TqYaN0GWaoiWp i2EukZA6qqDSlmNPLHgBtZ0RaBtE7txRrjwPbUnomPZKzHlBI7HelYpK7Xi3TSy4 A+DXjZ8Hhg0Lvgtfmz0BSDM4CM00+PzORkTd/MWIBEEAerJ/UCp97mjXe6Q2DBoF CStyIyWgqhCNgKqPERagSITEqs/qe4MGxwzl+CeHwcm7Sq1p4RrVwPrP51i3yBTH AKItagmnq1qKML8kxu12Xy7r7Enux7xiSPisT4gKBdlITcIB1wrfaSw74EsElOQT q1XnEnPochA84CX7OvMvifRRzOJqI773Wkje+pqR3Dq7zj8ECAPHDxVk4yjjoZ+T IdL83Q5vSE6gWMMccc+9lTmG5ks2bSgsCx2RDHj7DsYlQ0vLA4iklHFQnZq+qv+Q H1FbxJqemLnRsJodQi8T7BWGAVICZuRDFvB6V+8dNg6hP1APOdEWaRxdeOVKOZ5g 2+7vJ5n1blBC3HTLPtNYZPOQAelmm1pSQx6qGC9oRm5eNQyyiwEu3xQ0on2RfOic lQ/dLgy0aZ1QoH1LF85U =k6/G -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v--