From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZzNmy-0006DT-4f
	for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:54:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZzNmu-0008EP-Jc
	for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:54:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38753)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZzNmu-0008EE-EN
	for qemu-devel@nongnu.org; Thu, 19 Nov 2015 06:54:04 -0500
Date: Thu, 19 Nov 2015 11:53:59 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20151119115359.GD9247@redhat.com>
References: <1447879178-5440-1-git-send-email-afaerber@suse.de>
	<CAFEAcA887vEkCLDMLsvmwVtrvnDDyvnahPK-ruAzbJ6ocyWJLA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA887vEkCLDMLsvmwVtrvnDDyvnahPK-ruAzbJ6ocyWJLA@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL for-2.5 00/10] QOM devices patch queue
	2015-11-18
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Pavel Fedin <p.fedin@samsung.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>, QEMU Developers <qemu-devel@nongnu.org>

On Thu, Nov 19, 2015 at 10:54:15AM +0000, Peter Maydell wrote:
> On 18 November 2015 at 20:39, Andreas F=C3=A4rber <afaerber@suse.de> wr=
ote:
> > Hello Peter,
> >
> > This is my late QOM (devices) patch queue. Please pull.
> >
> > Regards,
> > Andreas
> >
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Cc: Daniel P. Berrange <berrange@redhat.com>
> > Cc: Pavel Fedin <p.fedin@samsung.com>
> >
> > The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98f=
d7be5f:
> >
> >   hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-1=
1-12 21:30:42 +0000)
> >
> > are available in the git repository at:
> >
> >   git://github.com/afaerber/qemu-cpu.git tags/qom-devices-for-peter
> >
> > for you to fetch changes up to c5760450796433621ccdc125866a84b892e2d5=
b6:
> >
> >   MAINTAINERS: Add check-qom-{interface,proplist} to QOM (2015-11-18 =
21:13:50 +0100)
> >
> > ----------------------------------------------------------------
> > QOM infrastructure fixes and device conversions
> >
> > * Fix for properties on objects > 4 GiB
> > * Performance improvements for QOM property handling
> > * Assertion cleanups
> > * MAINTAINERS additions
>=20
> Hi. Unfortunately this doesn't build with our minimum supported
> glib version:
>=20
> /Users/pm215/src/qemu-for-merges/qom/object.c:921:9: warning: implicit
> declaration of function 'g_hash_table_contains' is invalid in C99
> [-Wimplicit-function-declaration]
>     if (g_hash_table_contains(obj->properties, name)) {
>         ^
>=20
> g_hash_table_contains was only introduced in glib 2.32.

Since we never store NULL as a valid value in the hash tble, we
can simply replace this with g_hash_table_lookup instead

Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|