Re: [Qemu-devel] [PATCH] typedefs: Put them back into alphabetical order

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Nov 19, 2015 at 01:03:39PM +0000, Dr. David Alan Gilbert wrote:
> * Markus Armbruster (armbru@redhat.com) wrote:
> > "Please keep this list in alphabetical order" has been more honoured
> > in the breach than in the observance.  Clean up.
> > 
> > While there, drop a redundant struct declaration.
> > 
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> Hmph, it's only a year since I sorted this file.
> At least one of these changes is from a misordering within one patch!

Which just goes to show that any such rules about sorting are
not worth the hassle unless you also provide some make rule to
validate them as part of 'make test'. It shouldn't be too
hard to hook it up - a make rule that runs this:

   grep typedef include/qemu/typedefs.h > orig.txt
   sort orig.txt > sorted.txt
   diff orig.txt sorted.txt > /dev/null

as part of 'make test' would suffice

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|