From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzhzy-0000j1-DN for qemu-devel@nongnu.org; Fri, 20 Nov 2015 04:28:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zzhzw-0002dc-Vl for qemu-devel@nongnu.org; Fri, 20 Nov 2015 04:28:54 -0500 Date: Fri, 20 Nov 2015 18:02:56 +1100 From: David Gibson Message-ID: <20151120070256.GA7118@voom.redhat.com> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-15-git-send-email-benh@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: <1447201710-10229-15-git-send-email-benh@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 14/77] ppc: Change 'invalid' bit mask of tlbiel and tlbie List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 11, 2015 at 11:27:27AM +1100, Benjamin Herrenschmidt wrote: > Otherwise it will trip on the forms used in recent architecture. >=20 > Ideally, we should have different handlers for different architecture > levels but our current implementation of TLB flushing is dumb enough > that this will do for now. >=20 > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson > --- > target-ppc/translate.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 014fe5e..bd5df40 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -9952,8 +9952,10 @@ GEN_HANDLER2(slbmfee, "slbmfee", 0x1F, 0x13, 0x1C,= 0x001F0001, PPC_SEGMENT_64B), > GEN_HANDLER2(slbmfev, "slbmfev", 0x1F, 0x13, 0x1A, 0x001F0001, PPC_SEGME= NT_64B), > #endif > GEN_HANDLER(tlbia, 0x1F, 0x12, 0x0B, 0x03FFFC01, PPC_MEM_TLBIA), > -GEN_HANDLER(tlbiel, 0x1F, 0x12, 0x08, 0x03FF0001, PPC_MEM_TLBIE), > -GEN_HANDLER(tlbie, 0x1F, 0x12, 0x09, 0x03FF0001, PPC_MEM_TLBIE), > +/* XXX Those instructions will need to be handled differently for > + * different ISA versions */ > +GEN_HANDLER(tlbiel, 0x1F, 0x12, 0x08, 0x001F0001, PPC_MEM_TLBIE), > +GEN_HANDLER(tlbie, 0x1F, 0x12, 0x09, 0x001F0001, PPC_MEM_TLBIE), > GEN_HANDLER(tlbsync, 0x1F, 0x16, 0x11, 0x03FFF801, PPC_MEM_TLBSYNC), > #if defined(TARGET_PPC64) > GEN_HANDLER(slbia, 0x1F, 0x12, 0x0F, 0x03FFFC01, PPC_SLBI), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWTsWgAAoJEGw4ysog2bOSrTIQAJDXjfHBQGG8uGys0TcD54WI S5pMqD/4dEBs8WQZ+8KdBRCK5PVvQYG2G/jUJES7oRYAfs/V5rGT0qQn9E6pZbvr rAgUwa9vmzFyDknaR2toea2nBmm+U4FyBtDDEPDIt0FsW8knoOUlDyCKSNjHNA5b jmHNekm8oSWxz2XSDL5ZVWiHp4c0NLhsQs3qbpW4czznGryBr/iZdOhvBGoxHEIr 4QKFsbylIN/PWz9Azvs4GjJqe+ha7qdHaAxUBN2V10b/GnX8Yif8x50ugbiDEGBv V4VI9COz4g9CHK8unT9vRcFrrtpZG7W6l2fodLadpg3TeFPcekbxPqVES4e5SzyF 66+mo8HUe3T0WYYNGaedAWleWON7XH1AIm/rcHz72UlzMG03SrPY/Bnb9FHBx0Hm T8KKjIGFuufDB6NFsfocg6MRfpoy3DjUPAe+L8eaUereONoO5Ig28ALcK5NJioQ+ 5UflRUEo/P8/r/S/5TFGUP8kSnx0I8JGtTjvJ8Jx6xPQNEqQwlXWaYl6B9M2YKiO IOvqBkxl88jzkGR0L3gGW+DoFVKmUt3nMM6lgTS3b06yj01YqG7fiJ9jDRb/+ziB 0fQG6Pu1IQMR5yp4KPHLkRovCFaRX2IKQsPufj4N+rro3v7rxSGO7eKr1jJnGeVt UXA+3J5RLjtpNj13j9KT =SC3o -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--