From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzi00-0000jC-58 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 04:28:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zzhzw-0002dm-W8 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 04:28:56 -0500 Date: Fri, 20 Nov 2015 18:49:29 +1100 From: David Gibson Message-ID: <20151120074929.GD7118@voom.redhat.com> References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-24-git-send-email-benh@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6WlEvdN9Dv0WHSBl" Content-Disposition: inline In-Reply-To: <1447201710-10229-24-git-send-email-benh@kernel.crashing.org> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 23/77] ppc: Turn a bunch of booleans from int to bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org --6WlEvdN9Dv0WHSBl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 11, 2015 at 11:27:36AM +1100, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson > --- > target-ppc/translate.c | 39 +++++++++++++++++++-------------------- > 1 file changed, 19 insertions(+), 20 deletions(-) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 4d01fd0..a5ab2eb 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -189,21 +189,20 @@ struct DisasContext { > uint32_t opcode; > uint32_t exception; > /* Routine used to access memory */ > - bool pr, hv, dr; > + bool pr, hv, dr, le_mode; > int mem_idx; > int access_type; > /* Translation flags */ > - int le_mode; > TCGMemOp default_tcg_memop_mask; > #if defined(TARGET_PPC64) > - int sf_mode; > - int has_cfar; > + bool sf_mode; > + bool has_cfar; > #endif > - int fpu_enabled; > - int altivec_enabled; > - int vsx_enabled; > - int spe_enabled; > - int tm_enabled; > + bool fpu_enabled; > + bool altivec_enabled; > + bool vsx_enabled; > + bool spe_enabled; > + bool tm_enabled; > ppc_spr_t *spr_cb; /* Needed to check rights for mfspr/mtspr */ > int singlestep_enabled; > uint64_t insns_flags; > @@ -380,7 +379,7 @@ typedef struct opcode_t { > #if defined(CONFIG_USER_ONLY) > #define CHK_HV GEN_PRIV > #define CHK_SV GEN_PRIV > -#define CHK_HVDR GEN_PRIV > +#define CHK_HVRM GEN_PRIV > #else > #define CHK_HV do { if (unlikely(ctx->pr || !ctx->hv)) GEN_PRIV; } while= (0) > #define CHK_SV do { if (unlikely(ctx->pr)) GEN_PRIV; } while(0) > @@ -11407,31 +11406,31 @@ void gen_intermediate_code(CPUPPCState *env, st= ruct TranslationBlock *tb) > ctx.insns_flags =3D env->insns_flags; > ctx.insns_flags2 =3D env->insns_flags2; > ctx.access_type =3D -1; > - ctx.le_mode =3D env->hflags & (1 << MSR_LE) ? 1 : 0; > + ctx.le_mode =3D !!(env->hflags & (1 << MSR_LE)); > ctx.default_tcg_memop_mask =3D ctx.le_mode ? MO_LE : MO_BE; > #if defined(TARGET_PPC64) > ctx.sf_mode =3D msr_is_64bit(env, env->msr); > ctx.has_cfar =3D !!(env->flags & POWERPC_FLAG_CFAR); > #endif > - ctx.fpu_enabled =3D msr_fp; > + ctx.fpu_enabled =3D !!msr_fp; > if ((env->flags & POWERPC_FLAG_SPE) && msr_spe) > - ctx.spe_enabled =3D msr_spe; > + ctx.spe_enabled =3D !!msr_spe; > else > - ctx.spe_enabled =3D 0; > + ctx.spe_enabled =3D false; > if ((env->flags & POWERPC_FLAG_VRE) && msr_vr) > - ctx.altivec_enabled =3D msr_vr; > + ctx.altivec_enabled =3D !!msr_vr; > else > - ctx.altivec_enabled =3D 0; > + ctx.altivec_enabled =3D false; > if ((env->flags & POWERPC_FLAG_VSX) && msr_vsx) { > - ctx.vsx_enabled =3D msr_vsx; > + ctx.vsx_enabled =3D !!msr_vsx; > } else { > - ctx.vsx_enabled =3D 0; > + ctx.vsx_enabled =3D false; > } > #if defined(TARGET_PPC64) > if ((env->flags & POWERPC_FLAG_TM) && msr_tm) { > - ctx.tm_enabled =3D msr_tm; > + ctx.tm_enabled =3D !!msr_tm; > } else { > - ctx.tm_enabled =3D 0; > + ctx.tm_enabled =3D false; > } > #endif > if ((env->flags & POWERPC_FLAG_SE) && msr_se) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --6WlEvdN9Dv0WHSBl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWTtCJAAoJEGw4ysog2bOS3vMP/A2Fne2clAaLDhgwZu/MSVtK pG95nRKwQ2nbxndycC5FXcCtihnM+OntgdC5zFO26lntc6++XzLpq+yxuOj8n1Dp 1ZmrNy1y/SI0CgL2tcQp8qKJj7WYsZLNSawF9FWBIkkQuTLzTm7thMwvixL6mwkm y933MetDNdethPWuUEqNcv2kZxvQmgbWTPu/56D6mTE6a6goPpxMkv2CL4n3/fYc 7XQUymRiHoncwRDBIqU8UBbWP6tdNjFM5utqS2ZZ8ozuCBGL0HF6wAsDPlTp6SIe uahzwK0CjigGto8uVtLzsNvqF06uRFiBZTz50e4Ru6K53eV1MDt1mHDOon5jrE5d ODlRdajIkF8RizVqfA17yFWS4nV2kTURkLzbclQjkFLDnaQ37ILksApBRZWOHtND 0J8w/w/Wr17RcCUf4MjvV3/2GaQo8LZc5li/TGfTq/Qj6MasY9y85Mo88vCzeFJK Ilmy1kegRmN43xIwuZK6isyhGy+bATBdSp+68q9aPvIk6aMkwHbBA3vAnl6QI2dp 5tYaAoDroQfmVTEuYRbYmaZXGFee9izlH+bhg4R9wfIgtAo88Fe4SOfKJj+536I0 mVXw5OmLkrEQlBbafcfagV8YUe0XlNKDetLKWSCtg1t61kRsDbBtWkF6de7wtlWU LCB/M60ZeA3wLVsYlABr =gIDH -----END PGP SIGNATURE----- --6WlEvdN9Dv0WHSBl--